Skip to content

Conversation

@soodoshll
Copy link
Collaborator

Still working in progress.

  • The sequential (synchronous) matmul example is working.
  • Only shared memory + shared memory is supported. Didn't do register + share memory
  • Do we have a formatting script?

@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 4, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaoyaoding
Copy link
Member

Thanks @soodoshll !

Do we have a formatting script?

Yes:

uv pip install pre-commit
pre-commit run --all-files

Signed-off-by: Qidong Su <[email protected]>
Signed-off-by: Qidong Su <[email protected]>
Signed-off-by: Qidong Su <[email protected]>
Signed-off-by: Qidong Su <[email protected]>
Signed-off-by: Qidong Su <[email protected]>
Signed-off-by: Qidong Su <[email protected]>
Signed-off-by: Qidong Su <[email protected]>
Signed-off-by: Qidong Su <[email protected]>
Signed-off-by: Qidong Su <[email protected]>
Signed-off-by: Qidong Su <[email protected]>
Signed-off-by: Qidong Su <[email protected]>
@yaoyaoding
Copy link
Member

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 4, 2025

/ok to test

@yaoyaoding, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@yaoyaoding
Copy link
Member

/ok to test 1356e89

Signed-off-by: Qidong Su <[email protected]>
@soodoshll
Copy link
Collaborator Author

/ok to test 7ea0aba

Copy link
Member

@yaoyaoding yaoyaoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @soodoshll !

The PR looks good to me in general, I left a few minor suggestions. After fixing them, it's ready to go.

Signed-off-by: Qidong Su <[email protected]>
@soodoshll
Copy link
Collaborator Author

/ok to test 097a6c3

Signed-off-by: Qidong Su <[email protected]>
@soodoshll
Copy link
Collaborator Author

/ok to test 2c4e787

@yaoyaoding yaoyaoding mentioned this pull request Dec 5, 2025
17 tasks
@yaoyaoding
Copy link
Member

Added the PR to the roadmat #49

Signed-off-by: Qidong Su <[email protected]>
@soodoshll
Copy link
Collaborator Author

/ok to test e5b11ec

Signed-off-by: Qidong Su <[email protected]>
@soodoshll
Copy link
Collaborator Author

/ok to test 5c01c3e

@yaoyaoding yaoyaoding merged commit 9946b00 into NVIDIA:main Dec 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants