[CLUST-285] ansible server and client automatically setup - #147
Open
howardyu60211 wants to merge 51 commits into
Open
[CLUST-285] ansible server and client automatically setup#147howardyu60211 wants to merge 51 commits into
howardyu60211 wants to merge 51 commits into
Conversation
howardyu60211
changed the title
howardyu60211
marked this pull request as ready for review
May 18, 2026 10:50
howardyu60211
marked this pull request as draft
May 18, 2026 10:51
Member
|
I just noticed that we should test this function inside the container. We might need to install an SSH client in the container where our backend lives. |
joegoooo
reviewed
Jul 15, 2026
|
|
||
| if err = s.generateInventory(traceCtx); err != nil { | ||
| _, _ = s.queries.UpdateStatus(traceCtx, UpdateStatusParams{ID: id, Status: "failed"}) | ||
| return Server{}, fmt.Errorf("產生 inventory 失敗: %w", err) |
joegoooo
reviewed
Jul 15, 2026
|
|
||
| logger.Info("deploying all nodes...") | ||
| if err := exec.Execute(traceCtx); err != nil { | ||
| logger.Error("全叢集 Ansible 執行失敗", zap.Error(err)) |
Kyle9410-Chen
requested changes
Jul 16, 2026
…host provided, and merge database migration
Kyle9410-Chen
requested changes
Jul 30, 2026
Comment on lines
+13
to
+22
| type AnsibleInventory struct { | ||
| All AnsibleGroup `yaml:"all"` | ||
| } | ||
| type AnsibleGroup struct { | ||
| Vars map[string]interface{} `yaml:"vars,omitempty"` | ||
| Children map[string]AnsibleChild `yaml:"children,omitempty"` | ||
| } | ||
| type AnsibleChild struct { | ||
| Hosts map[string]HostVars `yaml:"hosts,omitempty"` | ||
| } |
Member
There was a problem hiding this comment.
There shouldn't be an Ansible prefix, which is the type in the Ansible package.
| InventoryFile = "hosts.yaml" | ||
| MainPlaybook = "playbooks/nodes.yaml" | ||
| LogFilePath = "ansible-deploy.log" | ||
| AnsibleDir = "internal/ansible/ansible" |
Member
There was a problem hiding this comment.
Variable names typically don't start with the package name.
| } | ||
|
|
||
| go s.runAnsibleInBackground(bgCtx, server) | ||
| bgCtx := context.WithoutCancel(ctx) |
Member
There was a problem hiding this comment.
It is better to use traceCtx here because of the span ID and logging.
|
|
||
| bgCtx := trace.ContextWithSpanContext(context.Background(), span.SpanContext()) | ||
| go s.runAnsibleInBackground(bgCtx, server) | ||
| bgCtx := context.WithoutCancel(ctx) |
Member
There was a problem hiding this comment.
It is better to use traceCtx here because of the span ID and logging.
|
|
||
| bgCtx := trace.ContextWithSpanContext(context.Background(), span.SpanContext()) | ||
| go s.runAnsibleInBackground(bgCtx, server) | ||
| bgCtx := context.WithoutCancel(ctx) |
Member
There was a problem hiding this comment.
It is better to use traceCtx here because of the span ID and logging.
| "ANSIBLE_CALLBACKS_ENABLED": "profile_tasks", | ||
| }), | ||
| ) | ||
| bgCtx := context.WithoutCancel(ctx) |
Member
There was a problem hiding this comment.
It is better to use traceCtx here because of the span ID and logging.
| bgCtx := trace.ContextWithSpanContext(context.Background(), span.SpanContext()) | ||
| go s.applySSSDConfig(bgCtx) | ||
| if server.AnsibleRole == computeNodeRole { | ||
| bgCtx := context.WithoutCancel(ctx) |
Member
There was a problem hiding this comment.
It is better to use traceCtx here because of the span ID and logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Purpose
Additional Information