Revise local container checking - #181
Open
Kyle9410-Chen wants to merge 4 commits into
Open
Conversation
Contributor
|
Is it better to just run |
Member
Author
|
For real. That makes sense. |
…equired containers
Contributor
|
Since it's one line and only used in Makefile, why not just make it inline? |
…using docker compose
Member
Author
|
Well, I updated it, and I removed the |
| clear: | ||
| @echo -e ":: $(GREEN)Cleaning up...$(NC)" | ||
| @echo -e " -> Stopping and removing depending services..." | ||
| @docker compose -f ./.deploy/local/compose.yaml down --remove-orphans \ |
Contributor
There was a problem hiding this comment.
should we add -v to clear the unnamed volume?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Purpose
make prepareand integrate tomake run.make clearto remove containers and the binary file.