Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for edited events to run the action on every PR edit #118

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

TheGoderGuy
Copy link
Contributor

@TheGoderGuy TheGoderGuy commented Nov 21, 2024

Hi,

we found this action doing exactly what we wanted, but need support for PR edits like title changes. We tried this changed action and it worked, maybe someone else needs this too.

Closes #117

@TheGoderGuy
Copy link
Contributor Author

@Namchee the workflow references to an image (version) which doesn't exist. Is there any way to get my pull request accepted or rejected? Of course, we can also fork the project, but we would like to participate instead of maintaining a side fork

@Namchee
Copy link
Owner

Namchee commented Nov 22, 2024

@TheGoderGuy, thanks for the PR!

I just noticed that it lacks edited event as this event is rarely fired for my personal use case 😅

As for the workflow run, I think I messed up the workflow somewhere in one of my old PR. I will fix this ASAP.

Copy link

github-actions bot commented Nov 22, 2024

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 22 Nov 24 13:58 UTC

@Namchee Namchee self-requested a review November 22, 2024 13:55
@Namchee
Copy link
Owner

Namchee commented Nov 22, 2024

Alright, there we go! I guess I'm gonna try to edit this PR to mention #117. If self-test passes, I'll merge this.

@TheGoderGuy
Copy link
Contributor Author

Yeah we thought so, not a typical case to listen on PR edits, but we thought we just try the simplest way to get to our goal :)
Thanks for fixing the checks!

@Namchee
Copy link
Owner

Namchee commented Nov 22, 2024

Alright, looks good to me!

@Namchee Namchee merged commit 80c04fc into Namchee:master Nov 22, 2024
2 checks passed
@Namchee
Copy link
Owner

Namchee commented Nov 22, 2024

@all-contributors, please add @TheGoderGuy for code.

Broken due to , nice.

@Namchee
Copy link
Owner

Namchee commented Nov 22, 2024

@all-contributors please add @TheGoderGuy for code

Copy link
Contributor

@Namchee

I've put up a pull request to add @TheGoderGuy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow usage of PR edited Event
2 participants