feat(providers): add luma-v2 targeting public-api.luma.com - #6922
feat(providers): add luma-v2 targeting public-api.luma.com#6922grayashh wants to merge 2 commits into
Conversation
3e879ed to
1493c33
Compare
|
Thanks for the contribution! Looking on our end, I can see there are connections that were recently created and successfully passed verification using the current verification endpoint. Would these changes introduce any breaking changes for those existing connections? |
|
I checked the three surfaces where existing connections touch this config, including the periodic re-verification ( 1. Re-verification of existing connections. Verified with a production API key that was created back when everything pointed at All three 200s return the same user object, so existing keys pass verification against the new endpoint unchanged. (Nango's 2. Proxy calls from existing integrations. As the 200s above show, 3. Nothing is removed on Luma's side. Their changelog (June 2026) is explicit about the old routes: "The replaced endpoints keep working and still return their original nested shape … including the deprecated fields." I also diffed One correction to my own PR description: it said connections proxying explicit Given that, I don't think a separate V2 provider is needed; both verification and proxy usage stay compatible for existing connections. Happy to split it out if you'd still prefer. |
1493c33 to
63f47b1
Compare
|
I would recommend creating a new version of the provider instead. Existing connections created with the current |
63f47b1 to
9161a76
Compare
|
Done. Reworked as a separate |
hassan254-prog
left a comment
There was a problem hiding this comment.
Thanks for updating this, for the docs please use the updated folder at /api-integrations and style to write the docs for this provider.
9161a76 to
6986ad4
Compare
6986ad4 to
124a3ac
Compare
Problem
The
lumaprovider targetshttps://api.lu.mawith verification against/public/v1/user/get-self. Luma's public API now lives athttps://public-api.luma.comwith routes under/v1/...: the current API reference documents only the new domain, and the conventions page describes the old routes as remaining "available for backward compatibility". We use this provider in production and override the base URL per request to reach the documented API.Fix
Per review feedback, this adds a separate
luma-v2provider instead of changinglumain place.luma-v2targetshttps://public-api.luma.comand verifies against/v1/users/get-self, the route Luma's authentication example uses. The existinglumaprovider is untouched, so existing connections see no change.Included per the provider conventions (same shape as
affinity-v2andpersonio-v2):providers.yamlentrydocs/integrations/all/luma-v2.mdx) anddocs.jsonnav entrynpm run docs:generate)luma-v2template logonpm run test:providerspasses.