refactor(audit): address review comments on the audit consumer - #6958
Open
pfreixes wants to merge 1 commit into
Open
refactor(audit): address review comments on the audit consumer#6958pfreixes wants to merge 1 commit into
pfreixes wants to merge 1 commit into
Conversation
The sort comparator and its comment defended against a locale difference that cannot arise between pods running one image. Neither was needed: the comparator only existed to satisfy a type-aware lint rule that had already stopped firing once the array was narrowed to strings. `describe` carried a comment about which fields may be read out of the blob, which is a constraint on the caller rather than a description of the function. Renamed to `nonIdentifyingFields` so the name carries it, and trimmed the token comment to the part the code does not already say. Dropped the env test that only asserted zod rejects a fractional value. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
TBonnin
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups to review comments on #6954, which merged before they were addressed.
(string | undefined)[]tostring[]by a separate change.describetononIdentifyingFields. Its comment stated which fields may be read out of the audit blob — a constraint on the caller, not a description of what the function does. The name carries it instead. The token comment is trimmed to the part the code does not already say.No behaviour change: the same fields are logged, and the dedup token is byte-identical because
Array.prototype.sorton a string array already compares UTF-16 code units.Test plan
npm run ts-buildclean