fix(function): align types between types package and runner-sdk - #6964
Merged
Conversation
TBonnin
force-pushed
the
tbonnin/nan-6037/function-align-types
branch
from
July 30, 2026 15:31
750f6f1 to
c4076d1
Compare
TBonnin
commented
Jul 30, 2026
| requires: { connection: true, outbound: true, invoke: false }, | ||
| capabilities: { usesRecords: false, usesOutbound: true, usesCheckpoints: false, usesMetadata: false, usesInvoke: false }, | ||
| limits: { concurrency: { perConnection: 'max' } }, | ||
| input_schema_ref: '#/definitions/FunctionInput_github_fetchIssues', |
Collaborator
Author
There was a problem hiding this comment.
I was thinking storing the full reference into the json schema instead of just the name to make it more explicit. wdyt @kaposke ?
Contributor
There was a problem hiding this comment.
That's a great idea actually.
TBonnin
force-pushed
the
tbonnin/nan-6037/function-align-types
branch
from
July 31, 2026 08:35
c4076d1 to
b5bc733
Compare
kaposke
approved these changes
Jul 31, 2026
| requires: { connection: true, outbound: true, invoke: false }, | ||
| capabilities: { usesRecords: false, usesOutbound: true, usesCheckpoints: false, usesMetadata: false, usesInvoke: false }, | ||
| limits: { concurrency: { perConnection: 'max' } }, | ||
| input_schema_ref: '#/definitions/FunctionInput_github_fetchIssues', |
Contributor
There was a problem hiding this comment.
That's a great idea actually.
| limits, | ||
| input_schema_ref: toSchemaRef(inputName), | ||
| output_schema_ref: toSchemaRef(outputName), | ||
| model_schema_refs: models ? Object.keys(models).map((name) => `#/definitions/${name}`) : [], |
Contributor
There was a problem hiding this comment.
Nit
Suggested change
| model_schema_refs: models ? Object.keys(models).map((name) => `#/definitions/${name}`) : [], | |
| model_schema_refs: models ? Object.keys(models).map(toSchemaRef) : [], |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
TBonnin
force-pushed
the
tbonnin/nan-6037/function-align-types
branch
from
August 3, 2026 09:32
b0b8847 to
2963ab6
Compare
marcindobry
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit consolidates and align the types between
runner-sdkand thetypespackages