refactor(authz): make environment optional on request locals - #6971
Open
kaposke wants to merge 2 commits into
Open
refactor(authz): make environment optional on request locals#6971kaposke wants to merge 2 commits into
kaposke wants to merge 2 commits into
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 128 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Keep the newly added impersonation handler compatible with optional environment request locals after rebasing onto master. Co-authored-by: Cursor <cursoragent@cursor.com>
kaposke
force-pushed
the
gui/NAN-6468/refac-make-environment-optional-on-request-locals
branch
from
July 31, 2026 23:16
05d52bb to
1bb1d8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit of a pre-req for account-level keys and endpoints:
locals.environmenthas to be optional. Separating this because it touches many files, but most are 1 liners.Previously:
RequestLocalshad every field as optionals.RequestLocalsproperties.Required<RequestLocals>which is unprecise - not every property is there for real.So the typing was a lie for a lot of cases.
Now:
RequestLocalshave non-optional fields for everything that always gets filled.Partial<RequestLocals>(so I've inverted the game)RequestLocalsWithEnvironmentfor endpoints that need the environment (most public endpoints so far).asyncWrapperto validate that the environment is in-fact present, so we don't need to spread the typecheck everywhere.The typing should now be precise on every handler.