fix(webapp): guard Stripe init against empty publishable key - #6985
Open
Nishal77 wants to merge 1 commit into
Open
fix(webapp): guard Stripe init against empty publishable key#6985Nishal77 wants to merge 1 commit into
Nishal77 wants to merge 1 commit into
Conversation
loadStripe() was called unconditionally with globalEnv.publicStripeKey, which is an empty string on self-hosted/local instances with no Stripe key configured. Stripe.js throws for an empty string instead of resolving null, causing an uncaught promise rejection on every page load - including pre-auth pages like /signin - plus real network beacons fired to stripe.com before any login. Guard the call so stripePromise resolves to null when unconfigured. Downstream consumers already handle this: Plans.tsx has an existing `if (!stripe)` guard, and Stripe's <Elements> accepts a null-resolving promise by design.
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loadStripe() was called unconditionally with globalEnv.publicStripeKey, which is an empty string on self-hosted/local instances with no Stripe key configured. Stripe.js throws for an empty string instead of resolving null, causing an uncaught promise rejection on every page load - including pre-auth pages like /signin - plus real network beacons fired to stripe.com before any login.
Guard the call so stripePromise resolves to null when unconfigured. Downstream consumers already handle this: Plans.tsx has an existing
if (!stripe)guard, and Stripe's accepts a null-resolving promise by design.Related to #5640, which reported this exact crash for self-hosted instances. That issue and its fix (#5641) were auto-closed by the stale bot without maintainer review - confirmed the bug is still live on current master.
Closes #5640
cc @macko911 for review, you've touched this file/area most recently, tagging in case you have context on why the empty-key guard was never added.