Skip to content

feat: add terminal tab to workbench panel #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
broodcicada-glitch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add terminal tab to workbench panel #1059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions desktop/src/components/workbench/WorkbenchPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ArrowLeft, FolderOpen, Globe, Maximize2, X } from 'lucide-react'
import { ArrowLeft, FolderOpen, Globe, Maximize2, SquareTerminal, X } from 'lucide-react'
import { useTranslation } from '../../i18n'
import {
useWorkspacePanelStore,
Expand All @@ -8,6 +8,7 @@ import { useBrowserPanelStore } from '../../stores/browserPanelStore'
import { WORKBENCH_TAB_PREFIX, useTabStore } from '../../stores/tabStore'
import { WorkspacePanel } from '../workspace/WorkspacePanel'
import { BrowserSurface } from '../browser/BrowserSurface'
import { TerminalSettings } from '../../pages/TerminalSettings'

type WorkbenchPanelProps = {
sessionId: string
Expand All @@ -17,11 +18,12 @@ type WorkbenchPanelProps = {

const MODE_ITEMS: ReadonlyArray<{
mode: WorkbenchMode
labelKey: 'workbench.modeWorkspace' | 'workbench.modeBrowser'
labelKey: any
Icon: typeof FolderOpen
}> = [
{ mode: 'workspace', labelKey: 'workbench.modeWorkspace', Icon: FolderOpen },
{ mode: 'browser', labelKey: 'workbench.modeBrowser', Icon: Globe },
{ mode: 'terminal' as any, labelKey: 'workbench.modeTerminal', Icon: SquareTerminal },
]

/**
Expand Down Expand Up @@ -140,6 +142,13 @@ export function WorkbenchPanel({ sessionId, variant = 'panel', onClose }: Workbe
<div className="flex min-h-0 flex-1 flex-col">
{mode === 'browser' ? (
<BrowserSurface sessionId={sessionId} />
) : (mode as string) === 'terminal' ? (
<TerminalSettings
workspace
docked
runtimeId={`workbench-terminal-${sessionId}`}
onClose={() => setMode(sessionId, 'workspace')}
/>
) : (
<WorkspacePanel sessionId={sessionId} embedded forceVisible={isTabVariant} />
)}
Expand Down
Loading