Skip to content

fix(chat): avoid false file output cards - #1171

Merged
NanmiCoder merged 1 commit into
NanmiCoder:mainfrom
toBerlinWay:fix/1035-output-target-empty-turn
Aug 2, 2026
Merged

fix(chat): avoid false file output cards#1171
NanmiCoder merged 1 commit into
NanmiCoder:mainfrom
toBerlinWay:fix/1035-output-target-empty-turn

Conversation

@toBerlinWay

@toBerlinWay toBerlinWay commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

TL;DR

修复了回复里提到文件、但本轮实际上没有改文件时,Activity 面板仍会展示错误文件卡片的问题。

Fixes #1035

改动点

  • 快照明确记录 changedFiles: [] 时,不再从回复文字里猜文件,只保留网址等非文件内容。
  • 快照缺失时仍保留原来的文字识别,兼容旧会话和异常回退。
  • 服务端会保留“本轮没有改文件”的可靠记录,界面也不会生成空卡片。

测试

  • 相关单元测试全部通过(149/149 passed)。
  • 覆盖空修改快照、localhost 链接、缺失快照回退和界面卡片过滤。
  • 当前 GitHub Actions 的桌面检查已通过;服务端与覆盖率检查被仓库现有 CI 环境问题挡住(缺少 adapter 依赖和 ripgrep),本次新增场景没有出现在失败断言中。

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

PR quality triage

Changed areas: area:desktop, area:server

CLI core policy: No CLI-core policy block detected.

Missing-test policy: No missing-test policy block detected.

Coverage baseline policy: No coverage-baseline policy block detected.

CLI core files:

  • none

Coverage policy files:

  • none

Required check plan:

  • See PR Quality / scope-plan; it is the single source of truth for selected jobs.

Test coverage signals:

  • No obvious missing-test signal from changed paths.

Risk notes:

  • No special risk notes from changed paths.

Hard merge gates come from the deterministic GitHub Actions contract lanes above.

@toBerlinWay
toBerlinWay marked this pull request as ready for review August 2, 2026 07:21
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

补充一下:最新重跑中 desktop-checks 和本次新增场景都已通过。server-checks 仍受 runner 缺少 @whiskeysockets/baileysripgrep 影响;coverage-checks 卡在另一个 MessageList 选区用例,本次文件卡片相关断言没有失败。需要补充针对性验证的话,我可以继续跟进。

@NanmiCoder
NanmiCoder merged commit 96a3a36 into NanmiCoder:main Aug 2, 2026
20 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:desktop area:server bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] AssistantOutputTargetCard 很容易展示不存在的文件。

2 participants