Skip to content

fix(activity): keep subagent bash tasks out of main session - #1172

Merged
NanmiCoder merged 1 commit into
NanmiCoder:mainfrom
toBerlinWay:fix/1142-subagent-background-task-leak
Aug 2, 2026
Merged

fix(activity): keep subagent bash tasks out of main session#1172
NanmiCoder merged 1 commit into
NanmiCoder:mainfrom
toBerlinWay:fix/1142-subagent-background-task-leak

Conversation

@toBerlinWay

@toBerlinWay toBerlinWay commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

TL;DR

修复了子 Agent 的后台命令出现在主会话 Activity 面板里,点击停止后又报“找不到任务”的问题。

Fixes #1142

改动点

  • agentIdlocal_bash 任务不再向主会话发送启动事件。
  • 停止这类任务时,不再向主会话写入孤立的完成或失败状态。
  • 主会话自己的命令和子 Agent 整体任务仍保持原来的展示与停止行为。

测试

  • 相关单元测试全部通过(6/6 passed)。
  • 覆盖主任务兼容、子 Agent 任务隔离和停止事件处理。
  • 当前 GitHub Actions 中,本次改动覆盖的 framework.test.ts 已通过;服务端与覆盖率检查被同一 CI 环境问题挡住(缺少 adapter 依赖和 ripgrep)。另外,CLI core 门禁需要维护者添加 allow-cli-core-change 标签并批准。

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

PR quality triage

Changed areas: area:cli-core

CLI core policy: Blocked by policy until a maintainer applies allow-cli-core-change and approves the PR.

Missing-test policy: No missing-test policy block detected.

Coverage baseline policy: No coverage-baseline policy block detected.

CLI core files:

  • src/utils/sdkEventQueue.ts
  • src/utils/task/framework.test.ts
  • src/utils/task/framework.ts

Coverage policy files:

  • none

Required check plan:

  • See PR Quality / scope-plan; it is the single source of truth for selected jobs.

Test coverage signals:

  • Agent/model runtime path changed: use mock/request-shape tests in PR and maintainer live-model smoke before release.

Risk notes:

  • No special risk notes from changed paths.

Hard merge gates come from the deterministic GitHub Actions contract lanes above.

@toBerlinWay
toBerlinWay marked this pull request as ready for review August 2, 2026 07:21
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

补充一下:最新重跑中,本次新增的 framework.test.ts 单文件检查已通过。当前还需要维护者添加 allow-cli-core-change 并批准;server-checkscoverage-checks 仍受 runner 缺少 adapter 依赖和 ripgrep 影响。若改动范围可以接受,辛苦帮忙确认一下核心代码门禁。

@NanmiCoder
NanmiCoder merged commit fce17eb into NanmiCoder:main Aug 2, 2026
18 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:cli-core bug Something isn't working needs-maintainer-approval size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] subagent内产生的后台命令,会展示在主会话的活动面板中,点击停止会报错。

2 participants