Allow opting out of OpenStudio stdout logger silencing - #128
Open
nllong wants to merge 2 commits into
Open
Conversation
…_SANDBOX in README examples - stdout_suppression.py: allow opting out of the OpenStudio stdout logger silencing via OSMCP_SKIP_OPENSTUDIO_LOGGER_SILENCE for cases where the caller wants the raw logger output. - README.md: add the missing -e OSMCP_SANDBOX=posix flag to the Docker run examples so they match the documented sandbox behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Flip the opt-out flag to default to "true" (suppress) since a SWIG bindings issue writes OpenStudio logger output directly to process stdout, corrupting the MCP JSON-RPC context. Set OSMCP_SKIP_OPENSTUDIO_LOGGER_SILENCE=false/0/no to disable suppression for local debugging. Add a test covering the opt-out path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OSMCP_SKIP_OPENSTUDIO_LOGGER_SILENCEenvironment variable escape hatch instdout_suppression.pyso callers can opt out of the OpenStudio stdout logger being silenced (Logger.instance().standardOutLogger().setLogLevel(openstudio.Fatal)) when set to1/true/yes.-e OSMCP_SANDBOX=posix, matching the documented sandbox behavior described later in the file.Why
stdout_suppression.pydocstring) without needing a code change.Testing