In FASTSim, the model and the trim are maintained distinctly in the metadata and then merged to form the vehicle identifier (see https://github.com/NatLabRockies/fastsim-vehicles/blob/main/v1/fastsim-3/bev/nissan/leaf-24-kwh/2016/base/r1.yaml).
In Powertrain, we keep trim in the metadata but it's only an optional field and we don't use it to build our model key..
In addition, FASTSim stores models with powertrain as a directory structure (see https://github.com/NatLabRockies/fastsim-vehicles/tree/main/v1/fastsim-3) whereas Powertrain also lumps that into the vehicle slug. Having powertrain at the top level seems to improve the overall discoverability of the model repository.
To that end, let's update the powertrain schema to keep the model and the trim separate like: model: leaf, trim: 24 kwh and then merge them into the vehicle slug. Let's also add the powertrain as its own level in the ModelKey.
This is a breaking change for our schema and so we should defer this until we plan to do a larger model library update.
In FASTSim, the model and the trim are maintained distinctly in the metadata and then merged to form the vehicle identifier (see https://github.com/NatLabRockies/fastsim-vehicles/blob/main/v1/fastsim-3/bev/nissan/leaf-24-kwh/2016/base/r1.yaml).
In Powertrain, we keep trim in the metadata but it's only an optional field and we don't use it to build our model key..
In addition, FASTSim stores models with powertrain as a directory structure (see https://github.com/NatLabRockies/fastsim-vehicles/tree/main/v1/fastsim-3) whereas Powertrain also lumps that into the vehicle slug. Having powertrain at the top level seems to improve the overall discoverability of the model repository.
To that end, let's update the powertrain schema to keep the model and the trim separate like:
model: leaf,trim: 24 kwhand then merge them into the vehicle slug. Let's also add the powertrain as its own level in the ModelKey.This is a breaking change for our schema and so we should defer this until we plan to do a larger model library update.