Skip to content

Axes labels do not react to template variables changes #94 #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Axes labels do not react to template variables changes #94 #96

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
716186d
Merge pull request #2 from NatelEnergy/master
corpglory-dev Mar 18, 2020
f158d74
re-render layout
corpglory-dev Mar 18, 2020
2bbf7f3
plotlyReact -> createOrUpdatePlot
corpglory-dev Mar 18, 2020
e46dc83
rm console log
corpglory-dev Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 24 additions & 33 deletions src/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,23 +422,9 @@ class PlotlyPanelCtrl extends MetricsPanelCtrl {
return;
}

if (!this.initialized) {
const s = this.cfg.settings;

const options = {
showLink: false,
displaylogo: false,
displayModeBar: s.displayModeBar,
modeBarButtonsToRemove: ['sendDataToCloud'], //, 'select2d', 'lasso2d']
};

this.layout = this.getProcessedLayout();
this.layout.shapes = this.annotations.shapes;
let traces = this.traces;
if (this.annotations.shapes.length > 0) {
traces = this.traces.concat(this.annotations.trace);
}
Plotly.react(this.graphDiv, traces, this.layout, options);
const isLayoutChanged = !_.isEqual(this.layout, this.getProcessedLayout());
if (!this.initialized || isLayoutChanged) {
this.createOrUpdatePlot();

this.graphDiv.on('plotly_click', data => {
if (data === undefined || data.points === undefined) {
Expand Down Expand Up @@ -740,6 +726,26 @@ class PlotlyPanelCtrl extends MetricsPanelCtrl {
return true;
}

createOrUpdatePlot(): void {
const s = this.cfg.settings;

const options = {
showLink: false,
displaylogo: false,
displayModeBar: s.displayModeBar,
modeBarButtonsToRemove: ['sendDataToCloud'], //, 'select2d', 'lasso2d']
};

this.layout = this.getProcessedLayout();
this.layout.shapes = this.annotations.shapes;
let traces = this.traces;
if (this.annotations.shapes.length > 0) {
traces = this.traces.concat(this.annotations.trace);
}

Plotly.react(this.graphDiv, traces, this.layout, options);
}

onConfigChanged() {
// Force reloading the traces
this._updateTraceData(true);
Expand All @@ -762,22 +768,7 @@ class PlotlyPanelCtrl extends MetricsPanelCtrl {
if (!this.cfg.showAnnotations) {
this.annotations.clear();
}

const s = this.cfg.settings;
const options = {
showLink: false,
displaylogo: false,
displayModeBar: s.displayModeBar,
modeBarButtonsToRemove: ['sendDataToCloud'], //, 'select2d', 'lasso2d']
};
this.layout = this.getProcessedLayout();
this.layout.shapes = this.annotations.shapes;
let traces = this.traces;
if (this.annotations.shapes.length > 0) {
traces = this.traces.concat(this.annotations.trace);
}
console.log('ConfigChanged (traces)', traces);
Plotly.react(this.graphDiv, traces, this.layout, options);
this.createOrUpdatePlot();
}

this.render(); // does not query again!
Expand Down