Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🖌️ New website design #89

Open
wants to merge 93 commits into
base: main
Choose a base branch
from

Conversation

HassanZahirnia
Copy link

@HassanZahirnia HassanZahirnia commented Mar 16, 2025

✅ Completed Tasks:

  • Home page redesign
  • EAP banner redesign
  • Footer redesign
  • Navbar redesign
  • Improved docs layout
  • Mobile (Early Access Program) page redesign
  • Dark theme fixes
  • Documentation redesign
  • Added a "Sponsor us" button to the docs

🐞 Known Issues (all fixed):

  • Dark theme was not implemented (fixed)
  • Right sidebar on docs was broken (fixed)
  • Footer overlapping the docs sidebar due to new layout (fixed)

📌 TODO for Backend Development:

  1. Home page (welcome.blade.php):

    • Replace the "+ Many community contributors:" list with a dynamic list fetched via the GitHub API.
  2. Top navigation (navigation-bar.blade.php):

    • Replace the static "1.0.0-beta.2" version number next to the logo with a dynamic value fetched via the GitHub API.

😊 A gentle reminder to all members and contributors: Please consult me before making any visual or design changes. While I fully appreciate that this is an open-source project where everyone can contribute freely, I’d like to ensure we maintain a cohesive and polished design.

Thank you, hope you all like the new design! 🌸

…ith improved styling, and clean up unused code
…add logo component, and enhance layout responsiveness
…introduction section, and enhance mobile responsiveness
…ction margins, and enhance mobile image responsiveness
…personal websites, and enhance layout responsiveness
…sponsiveness; replace header banner with navigation bar
…nce sidebar navigation and documentation page layout
…ling; adjust z-index and background properties for better visibility
…djust dimensions and spacing for improved visual consistency
…he Early Access Program?" content for enhanced engagement
@HassanZahirnia
Copy link
Author

Just for reference, here's how the website looked before the redesign:

  1. Home page:
    Screenshot 2025-03-18 173944
  2. Mobile page:
    Screenshot 2025-03-18 173958
  3. Docs page
    Screenshot 2025-03-18 174012

@HassanZahirnia
Copy link
Author

For reference, here's how the old website previously scored on Google's PageSpeed Insights:
image
image
image

…tic structure in alert, footer, and navigation components
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HassanZahirnia! In case you haven’t noticed, you have multiple <h1> on this view.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Yeah I'm aware of this. Because of how I designed things and many decorative elements and animations I've had, I had to separate words which resulted in multiple H1 tags. I know it's not clean but Lighthouse is giving 100 score on the SEO so I don't think Google is gonna penalize our rank.
Also the words are on the same level so technically it should be ok.

But I'm no SEO expert. If anyone has a better approach, let me know. 😊

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's just about SEO, it's also about how screen readers will interpret the content.

Maybe a single <h1> with multiple <span> inside it is the way?

caveat: I'm also not an expert on either SEO or accessibility

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay then I also have 0 context about how screen readers work lol.
If your concern is only screen readers, I can make the entire decorative tagline hidden for screen readers, and then use a separate dedicated <h1> for the screen readers. Is that too hacky or it sounds fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants