fix: prevent crash when jweak points to null #1881
Merged
+40
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally (mostly on android API 26.1+) a jweak reference might point to NULL even when the actual Java object exists.
I believe this is a JNI/Android bug, but as a workaround, we now check if this reference is null, and if so we evict the key from the cache which then is going to re-fetch it and error out if it's actually null in Java