-
Notifications
You must be signed in to change notification settings - Fork 23
[FIX] demo layout issue fixed. progress bar added in to demo list #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the comments and make sure to run prettier
before pushing the code (ignore if already taken care).
can some one add pre commit hooks in package.json file. so before commit it'll check all code formats . |
@kvraamkey I am working on that already. Issue #37. I will raise the PR soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. We can merge this.
Thanks @madhuni and also we need to look on layout document instructions also. Because right now i ket auto pick from folder. Based upon this we need to do. |
@kvraamkey, sorry but I didn't understand what's the point you are raising here. Can you explain it in more detail? Maybe it's my fault that I am not aware of the point you are talking about. |
Yep, some one added navbar on top. But it was not the correct one. So i fixed those and raised PR |
|
@kvraamkey, let's wait for PR #49 to get merged first before we merge this PR. For more details please refer to my comment. |
No description provided.