Skip to content

[FIX] demo layout issue fixed. progress bar added in to demo list #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kvraamkey
Copy link
Contributor

No description provided.

Copy link
Contributor

@madhuni madhuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the comments and make sure to run prettier before pushing the code (ignore if already taken care).

@kvraamkey
Copy link
Contributor Author

can some one add pre commit hooks in package.json file. so before commit it'll check all code formats .

@madhuni
Copy link
Contributor

madhuni commented Jul 4, 2020

@kvraamkey I am working on that already. Issue #37.

I will raise the PR soon.

Copy link
Contributor

@madhuni madhuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. We can merge this.

@kvraamkey
Copy link
Contributor Author

Thanks @madhuni and also we need to look on layout document instructions also. Because right now i ket auto pick from folder. Based upon this we need to do.

@madhuni
Copy link
Contributor

madhuni commented Jul 4, 2020

@kvraamkey, sorry but I didn't understand what's the point you are raising here. Can you explain it in more detail? Maybe it's my fault that I am not aware of the point you are talking about.

@kvraamkey
Copy link
Contributor Author

Yep, some one added navbar on top. But it was not the correct one. So i fixed those and raised PR

@kvraamkey
Copy link
Contributor Author

@kvraamkey, sorry but I didn't understand what's the point you are raising here. Can you explain it in more detail? Maybe it's my fault that I am not aware of the point you are talking about.

#42 (comment)

@madhuni
Copy link
Contributor

madhuni commented Jul 7, 2020

@kvraamkey, let's wait for PR #49 to get merged first before we merge this PR. For more details please refer to my comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants