Improved doc for polynomial ring element constructors #2179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2179 +/- ##
=======================================
Coverage 87.92% 87.93%
=======================================
Files 127 127
Lines 31782 31802 +20
=======================================
+ Hits 27945 27964 +19
- Misses 3837 3838 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fingolfin
reviewed
Oct 1, 2025
docs/src/polynomial.md
Outdated
| (R::PolyRing{T})(a::T) where T <: RingElement | ||
| ``` | ||
| The third constructor above cannot be used to coerce a polynomial from one ring | ||
| to another; instead use evaluation, for instance: `f(y)` where `y` is the |
There was a problem hiding this comment.
But evaluation is not the best way. We can mention it, but really should be recommending map_coefficient here, ideally with a jldoctest usage example.
There was a problem hiding this comment.
I confirm that evaluation is impressively slow (and requires impressively much RAM): for the record, I tried mapping (x+1)^99999 from ZZ[x] to ZZ[y], and gave up after 600s CPU -- map_coefficients took less than 1s.
fingolfin
reviewed
Oct 6, 2025
Co-authored-by: Max Horn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a comment about how to coerce a polynomial from one ring to another; and stating that the constructors will not do this. See https://github.com/oscar-system/Oscar.jl/issues/5396