-
Notifications
You must be signed in to change notification settings - Fork 0
fuck #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuck #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates DLX routing logic by introducing a configurable DLX exchange name, adjusts fallback naming, and bumps the package version.
- Added
dlx_exhange_nameattribute and extended DLX handling methods to accept it - Changed DLX fallback from
queue_name.dlxtoexchange_name.dlx - Bumped version to 2.0.1 and updated release badge
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| reports/junit/junit.xml | Updated test report timestamp and runtime |
| pyproject.toml | Bumped package version from 2.0.0 to 2.0.1 |
| mrsal/superclass.py | Added dlx_exhange_name, updated DLX naming logic and method API |
| mrsal/amqp/subclass.py | Passed new DLX exchange name parameter to publishing methods |
| README.md | Updated release badge to 2.0.1 |
Comments suppressed due to low confidence (4)
mrsal/superclass.py:46
- The attribute name
dlx_exhange_nameis misspelled. Rename it todlx_exchange_nameto match its usage and avoid confusion.
dlx_exhange_name = None
mrsal/superclass.py:46
- Introduce tests for the new
dlx_exchange_nameconfiguration to ensure fallback naming and custom names behave as expected in both sync and async flows.
dlx_exhange_name = None
mrsal/amqp/subclass.py:375
- Using
self.dlx_exhange_nameties to the misspelled attribute. After renaming the attribute, update this reference toself.dlx_exchange_name.
original_exchange, original_routing_key, self.dlx_exhange_name,
mrsal/amqp/subclass.py:592
- Referencing
self.dlx_exchange_namewill raise an AttributeError since the attribute is currently nameddlx_exhange_name. Align the property name and its usage.
original_exchange, original_routing_key, self.dlx_exchange_name,
|
sjekk copilot review, det er litt true? |
MartinRovang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copilot review
dlx routing fixed