Skip to content

Conversation

@JonNesvold
Copy link
Contributor

dlx routing fixed

@JonNesvold JonNesvold requested a review from MartinRovang July 2, 2025 07:55
@MartinRovang MartinRovang requested a review from Copilot July 2, 2025 07:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates DLX routing logic by introducing a configurable DLX exchange name, adjusts fallback naming, and bumps the package version.

  • Added dlx_exhange_name attribute and extended DLX handling methods to accept it
  • Changed DLX fallback from queue_name.dlx to exchange_name.dlx
  • Bumped version to 2.0.1 and updated release badge

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
reports/junit/junit.xml Updated test report timestamp and runtime
pyproject.toml Bumped package version from 2.0.0 to 2.0.1
mrsal/superclass.py Added dlx_exhange_name, updated DLX naming logic and method API
mrsal/amqp/subclass.py Passed new DLX exchange name parameter to publishing methods
README.md Updated release badge to 2.0.1
Comments suppressed due to low confidence (4)

mrsal/superclass.py:46

  • The attribute name dlx_exhange_name is misspelled. Rename it to dlx_exchange_name to match its usage and avoid confusion.
	dlx_exhange_name = None

mrsal/superclass.py:46

  • Introduce tests for the new dlx_exchange_name configuration to ensure fallback naming and custom names behave as expected in both sync and async flows.
	dlx_exhange_name = None

mrsal/amqp/subclass.py:375

  • Using self.dlx_exhange_name ties to the misspelled attribute. After renaming the attribute, update this reference to self.dlx_exchange_name.
				original_exchange, original_routing_key, self.dlx_exhange_name,

mrsal/amqp/subclass.py:592

  • Referencing self.dlx_exchange_name will raise an AttributeError since the attribute is currently named dlx_exhange_name. Align the property name and its usage.
				original_exchange, original_routing_key, self.dlx_exchange_name,

@MartinRovang
Copy link
Contributor

sjekk copilot review, det er litt true?

Copy link
Contributor

@MartinRovang MartinRovang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copilot review

@JonNesvold JonNesvold requested a review from MartinRovang July 2, 2025 09:46
@JonNesvold JonNesvold merged commit 3ae6ded into main Jul 2, 2025
@JonNesvold JonNesvold deleted the routing-fail branch July 6, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants