Add: Imperial support to DivePlanner by passing the UnitSystem enum - #179
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 70.10% 70.15% +0.05%
==========================================
Files 145 145
Lines 7830 7847 +17
Branches 973 977 +4
==========================================
+ Hits 5489 5505 +16
- Misses 1850 1851 +1
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
`DivePlanner.addDive()` is now aware of the `UnitSystem`. When `UnitSystem.IMPERIAL` is active, output depths are produced in feet and deco stops align to the 10 feet grid. Required for: #49
Rolf-Smit
force-pushed
the
feature/make-diveplanner-unit-system-aware
branch
from
May 4, 2026 22:45
e48fdc4 to
4aba438
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DivePlanner.addDive()is now aware of theUnitSystem. WhenUnitSystem.IMPERIALis active, output depths are produced in feet and deco stops align to the 10 feet grid.Required for: #49