Skip to content

Add: Imperial support to DivePlanner by passing the UnitSystem enum - #179

Merged
Rolf-Smit merged 1 commit into
mainfrom
feature/make-diveplanner-unit-system-aware
May 4, 2026
Merged

Add: Imperial support to DivePlanner by passing the UnitSystem enum#179
Rolf-Smit merged 1 commit into
mainfrom
feature/make-diveplanner-unit-system-aware

Conversation

@Rolf-Smit

Copy link
Copy Markdown
Contributor

DivePlanner.addDive() is now aware of the UnitSystem. When UnitSystem.IMPERIAL is active, output depths are produced in feet and deco stops align to the 10 feet grid.

Required for: #49

@codecov-commenter

codecov-commenter commented May 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.15%. Comparing base (e2052a2) to head (4aba438).

Files with missing lines Patch % Lines
...ech/app/abysner/domain/diveplanning/DivePlanner.kt 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   70.10%   70.15%   +0.05%     
==========================================
  Files         145      145              
  Lines        7830     7847      +17     
  Branches      973      977       +4     
==========================================
+ Hits         5489     5505      +16     
- Misses       1850     1851       +1     
  Partials      491      491              
Flag Coverage Δ
domain 78.14% <91.66%> (+0.17%) ⬆️
presentation 68.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

`DivePlanner.addDive()` is now aware of the `UnitSystem`. When `UnitSystem.IMPERIAL` is active, output depths are produced in feet and deco stops align to the 10 feet grid.

Required for: #49
@Rolf-Smit
Rolf-Smit force-pushed the feature/make-diveplanner-unit-system-aware branch from e48fdc4 to 4aba438 Compare May 4, 2026 22:45
@Rolf-Smit
Rolf-Smit merged commit 80009a5 into main May 4, 2026
4 checks passed
@Rolf-Smit
Rolf-Smit deleted the feature/make-diveplanner-unit-system-aware branch May 4, 2026 23:02
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants