Skip to content

Add: Imperial unit support for depth and distance/rate in the UI - #181

Merged
Rolf-Smit merged 1 commit into
mainfrom
feature/imperial-depth-units
May 5, 2026
Merged

Add: Imperial unit support for depth and distance/rate in the UI#181
Rolf-Smit merged 1 commit into
mainfrom
feature/imperial-depth-units

Conversation

@Rolf-Smit

Copy link
Copy Markdown
Contributor

Required for: #49

@Rolf-Smit
Rolf-Smit force-pushed the feature/imperial-depth-units branch from 426d909 to 34ddef3 Compare May 5, 2026 10:51
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.24138% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.98%. Comparing base (854b5ec) to head (34ddef3).

Files with missing lines Patch % Lines
...er/presentation/screens/DiveConfigurationScreen.kt 33.89% 28 Missing and 11 partials ⚠️
...reens/planner/segments/SegmentPickerBottomSheet.kt 61.53% 8 Missing and 2 partials ⚠️
...sentation/screens/planner/decoplan/DecoPlanCard.kt 64.28% 5 Missing ⚠️
...app/abysner/presentation/screens/SettingsScreen.kt 75.00% 2 Missing and 1 partial ⚠️
...r/presentation/component/GasPropertiesComponent.kt 60.00% 0 Missing and 2 partials ⚠️
...resentation/screens/planner/PlanScreenViewModel.kt 80.00% 0 Missing and 1 partial ⚠️
...ens/planner/cylinders/CylinderPickerBottomSheet.kt 80.00% 1 Missing ⚠️
...resentation/screens/planner/gasplan/GasPlanCard.kt 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   70.14%   69.98%   -0.16%     
==========================================
  Files         145      145              
  Lines        7840     7925      +85     
  Branches      978      992      +14     
==========================================
+ Hits         5499     5546      +47     
- Misses       1849     1877      +28     
- Partials      492      502      +10     
Flag Coverage Δ
domain 78.12% <ø> (-0.02%) ⬇️
presentation 67.95% <57.24%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Rolf-Smit
Rolf-Smit merged commit 10ce923 into main May 5, 2026
4 checks passed
@Rolf-Smit
Rolf-Smit deleted the feature/imperial-depth-units branch May 5, 2026 12:01
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants