Skip to content

Add: Imperial unit support for pressure and capacity in the UI - #182

Merged
Rolf-Smit merged 1 commit into
mainfrom
feature/imperial-pressure-units
May 5, 2026
Merged

Add: Imperial unit support for pressure and capacity in the UI#182
Rolf-Smit merged 1 commit into
mainfrom
feature/imperial-pressure-units

Conversation

@Rolf-Smit

Copy link
Copy Markdown
Contributor

Required for: #49

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.08333% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.11%. Comparing base (10ce923) to head (ca72f9d).

Files with missing lines Patch % Lines
...er/presentation/screens/DiveConfigurationScreen.kt 39.39% 10 Missing and 10 partials ⚠️
...bysner/presentation/component/CylinderSizeField.kt 81.42% 12 Missing and 1 partial ⚠️
...n/screens/planner/gasplan/GasUsageDetailsDialog.kt 62.96% 7 Missing and 3 partials ⚠️
...ens/planner/cylinders/CylinderPickerBottomSheet.kt 63.15% 7 Missing ⚠️
...ntation/screens/planner/cylinders/CylindersCard.kt 66.66% 3 Missing ⚠️
...resentation/screens/planner/gasplan/GasBarChart.kt 94.44% 0 Missing and 1 partial ⚠️
...resentation/screens/planner/gasplan/GasPlanCard.kt 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   69.98%   70.11%   +0.13%     
==========================================
  Files         145      145              
  Lines        7925     8099     +174     
  Branches      992     1031      +39     
==========================================
+ Hits         5546     5679     +133     
- Misses       1877     1908      +31     
- Partials      502      512      +10     
Flag Coverage Δ
domain 78.12% <ø> (ø)
presentation 68.18% <77.08%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Rolf-Smit
Rolf-Smit merged commit fc025f1 into main May 5, 2026
4 checks passed
@Rolf-Smit
Rolf-Smit deleted the feature/imperial-pressure-units branch May 5, 2026 17:30
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants