-
Notifications
You must be signed in to change notification settings - Fork 92
Do not pre-validate restrictions #855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0fc1f3b
to
a29cb18
Compare
@kwin there is another restrictions pre-validation in Lines 134 to 144 in 8fdc6ba
|
a29cb18
to
1c4b417
Compare
Oak takes care of that in https://github.com/apache/jackrabbit-oak/blob/17281282fe82d0f0c4e86d0a42ecfb20bfe404e3/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/accesscontrol/ACL.java#L213 as soon as you try to apply those. Otherwise you face exceptions when using restrictions only available at run-time in cloud (but not at build time). This closes #854
4662ece
to
d6dfc43
Compare
|
restrictions: | ||
rep:Glob: /cq:* | ||
assertedException: InvalidRestrictionsException | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not just remove assertedException
but then also the test case with the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me this test shows that invalid restrictions do no longer lead to exceptions, therefore this is still helpful.
Oak takes care of that in
https://github.com/apache/jackrabbit-oak/blob/17281282fe82d0f0c4e86d0a42ecfb20bfe404e3/oak-core/src/main/java/org/apache/jackrabbit/oak/security/authorization/accesscontrol/ACL.java#L213 as soon as you try to apply those.
Otherwise you face exceptions when using restrictions only available at run-time in cloud (but not at build time).
This closes #854