Improve baseline cost output format to show all clusters#214
Merged
homatthew merged 1 commit intoNetflix-Skunkworks:mainfrom Jan 26, 2026
Merged
Improve baseline cost output format to show all clusters#214homatthew merged 1 commit intoNetflix-Skunkworks:mainfrom
homatthew merged 1 commit intoNetflix-Skunkworks:mainfrom
Conversation
The previous format only showed instance info from the first cluster, which was misleading for composite models like Key-Value that have multiple cluster types (Cassandra, EVCache, dgwkv). Changes: - Show all clusters with full details: cluster_type, deployment (zonal/regional), instance, count, annual_cost - Add attached_drives field per cluster (only when drives exist) - Remove misleading single instance_name/instance_count/deployment fields This makes the baseline output self-documenting and easier to review when costs change. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous format only showed instance info from the first cluster, which was misleading for composite models like Key-Value that have multiple cluster types (Cassandra, EVCache, dgwkv).
cluster_type,deployment(zonal/regional),instance,count,annual_costattached_drivesfield per cluster (only when drives exist)instance_name/instance_count/deploymentfieldsThis makes the baseline output self-documenting and easier to review when costs change.
Example:
kv_with_cache(before){ "instance_name": "c6id.2xlarge", "instance_count": 39, "deployment": "zonal", ... }Example:
kv_with_cache(after){ "clusters": [ {"cluster_type": "evcache", "deployment": "zonal", "instance": "c6id.2xlarge", "count": 39, ...}, {"cluster_type": "cassandra", "deployment": "zonal", "instance": "c5d.12xlarge", "count": 2, ...}, {"cluster_type": "dgwkv", "deployment": "regional", "instance": "c7a.2xlarge", "count": 78, "attached_drives": ["gp2 : 20GB"], ...} ], ... }Test plan
tox -e pre-commitpassestox -e capture-baselineregenerates with new format🤖 Generated with Claude Code