feat(signals): new endpoint for signal data #5837
Open
+267
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to the signal module, allowing users to retrieve signal data based on a given entity name and type. The changes include the addition of a new endpoint, the necessary backend logic to support this functionality, and comprehensive tests to ensure reliability.
Key Changes:
New Model:
SignalData
model to encapsulate the response structure for the new endpoint, including fields for the number of signals alerted, snoozed, and the status of snoozes (active or expired).Service Layer:
get_signal_data
function inservice.py
to query the database for signal data based on the provided entity name and type.num_days
to allow filtering signals based on a date threshold.API Endpoint:
/data
inviews.py
to expose the signal data retrieval functionality.entity_value
,entity_type_id
, andnum_days
.Testing:
test_signal_data_service.py
to verify the functionality ofget_signal_data
.Enhancements: