Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snooze): request longer snooze #5862

Merged
merged 3 commits into from
Mar 31, 2025
Merged

Conversation

whitdog47
Copy link
Contributor

@whitdog47 whitdog47 commented Mar 30, 2025

This pull request introduces the ability to request a longer snooze period for signals within the Slack integration.

Key changes:

  • Database Migration:
    • Adds snooze_extension_oncall_service_id to the project table to associate an on-call service with snooze extension requests.
    • Includes corresponding upgrade and downgrade Alembic migrations.
  • Slack Interactive Elements:
    • Adds a checkbox (extension_request_checkbox) in the snooze creation modal to allow users to request a longer snooze.
    • Updates the snooze submission handler (handle_snooze_submission_event) to process this request.
  • Snooze Message Enhancement:
    • Modifies the snooze notification message (post_snooze_message) to indicate if an extension was requested and notifies the on-call user.
    • Adds a function get_user_id_from_oncall_service to get the slack user id from the oncall service.
  • Project Model Update:
    • Adds snooze_extension_oncall_service relationship to the Project model.
    • Adds snooze_extension_oncall_service_id to ProjectBase, ProjectCreate, and ProjectUpdate models.
  • Vue UI Changes:
    • Adds a ServiceSelect component to the NewEditSheet.vue to allow project admins to select the oncall service for snooze extensions.
    • Updates the project store to handle the new field.
  • Testing:
    • Adds comprehensive unit tests for the new snooze functionality, including handling of MFA challenges and on-call service notifications.

Benefits:

  • Provides users with the flexibility to request longer snooze durations when necessary.
  • Ensures that on-call personnel are notified when a snooze extension is requested.
  • Improves the overall signal management workflow within Slack.

Screen shots:
image

image

@whitdog47 whitdog47 self-assigned this Mar 31, 2025
@whitdog47 whitdog47 added the enhancement New feature or request label Mar 31, 2025
@whitdog47 whitdog47 merged commit bb9c99d into main Mar 31, 2025
10 checks passed
@whitdog47 whitdog47 deleted the enhancement/request-longer-snooze branch March 31, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants