Allow MAX_ATTEMPTS configurable
#2279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll take a look a bit closer but one thing I can say already is that we probably want to min it with what is already there because otherwise if it is decreased, the client may misbehave. Related to that, I don't know if we can dis-associate it totally from the run in the client because again, otherwise, the client may misbehave. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I allow configuration of MAX_ATTEMPTS envar
New Behaviour
User can set
METAFLOW_MAX_ATTEMPTSto configureMAX_ATTEMPTSinternal envvar.Resolves: #2276