Ignore sepolia-devnet-2 L1 in superchain chainspec generation - #12398
Conversation
…ration The superchain registry added a sepolia-devnet-2 devnet whose L1 is not in the script's constants table, so generated chainspecs miss depositContractAddress while enabling EIP-6110, failing chainspec validation in Runner smoke tests (see PR #12395). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Claude finished @LukaszRozmej's task in 48s —— View job Code Review: Ignore sepolia-devnet-2 L1 in superchain chainspec generation
Verdict: ✅ Looks good — safe to mergeThe one-line change is correct and matches the existing pattern. Why it works: In Root-cause confirmed: The The change is minimal, focused, and consistent with the already-ignored FindingsLow (non-blocking, optional) — The No Critical / High / Medium issues found. |
Changes
sepolia-devnet-2toIGNORED_L1Sinscripts/superchain.py, alongside the already-ignoredsepolia-dev-0devnet.The superchain registry added a
sepolia-devnet-2/sepolia-devnet-2devnet whose L1 is not in the script's constants table (L1ChainId,L1BeaconGenesisSlotTime,DepositContractAddress). The generated chainspec then enables EIP-6110 (Isthmus) withoutdepositContractAddress, which fails chainspec validation and broke allNethermind.Runner.Testsmoke tests in #12395.After this change, the "Update OP Superchain chains" workflow needs a re-run to regenerate #12395 without the devnet files.
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
Notes on testing
Ran
scripts/superchain.pylocally: the devnet is now skipped (Ignoring 'sepolia-devnet-2-sepolia-devnet-2') and the remaining 49 chain configs generate unchanged.Documentation
Requires documentation update
Requires explanation in Release Notes
🤖 Generated with Claude Code