Glamsterdam devnet 8 specific commits - #12719
Conversation
Update Glamsterdam devnet fixtures to v8.1.0
…12713) * feat(eip-2780): fold EIP-7708 transfer log cost into TX_VALUE_COST Per the glamsterdam devnet-8 EIP-2780 update, the EIP-7708 transfer-log cost is folded into TX_VALUE_COST instead of being charged separately: - TxValueCostEip2780: 4244 -> 6000 (absorbs the 1756 transfer-log cost) - Remove the now-redundant TransferLogEip2780 constant (intrinsic-only) - Contract creation no longer charges the transfer log on a value endowment; the recipient balance write is covered by CREATE_ACCESS, so create-with-value and create-with-zero-value have identical intrinsic cost. A plain value transfer's total is unchanged (re-labeled); create-with-value drops by the folded 1756. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(eip-2780): pin Amsterdam create value-independence; fix comment accuracy Address review on #12713: - Clarify that the recipient balance write is covered by the create charge (CREATE_ACCESS under EIP-8038, with 8037/legacy fallbacks otherwise), rather than implying CREATE_ACCESS is unconditional. - Parameterize Eip2780_intrinsic_gas_for_create_is_value_independent over EIP-8038 on/off so the devnet-8 reference row (zero-value Amsterdam create) is pinned directly, and the asserted create charge matches the active config. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Claude finished @flcl42's task in 13m 32s —— View job Code review
SummaryThree devnet-8 commits: EEST fixture bump to I verified the arithmetic of essentially every updated expectation, and it holds up well:
Findings are inline; nothing blocks on correctness of the implementation — the open questions are all "does this match the devnet-8 spec text", which the code can't answer on its own.
3. The fixture bump is not green (Medium)CI on this PR is currently useless — nearly every
Good news: Note on test design
VerdictThe implementation is internally consistent and the test updates are correct. Blocking items are the three Medium findings — two need a spec citation (cheap to resolve), and one needs the |
EVM Opcode Benchmark DiffAggregated runs: base=3, pr=3 No significant regressions or improvements detected. |
Resolves #12599
Changes