Paymaster PR 1: new paymaster pkg #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagodeev
changed the title
thiagodeev
force-pushed
the
paymster-pr-1
branch
from
13992ab to
5dae8eb
Compare
thiagodeev
force-pushed
the
paymster-pr-1
branch
from
5dae8eb to
a0c2439
Compare
rodrigo-pino
approved these changes
Oct 13, 2025
paymaster/is_available_test.go
Outdated
| t.Parallel() | ||
| t.Run("integration", func(t *testing.T) { | ||
| tests.RunTestOn(t, tests.IntegrationEnv) | ||
| t.Parallel() |
There was a problem hiding this comment.
Why is t.Parallel() here?
There was a problem hiding this comment.
Indeed! Since there's only one subtest for this environment, there's no need for the t.Parallel() call.
I'll change it
paymaster/is_available_test.go
Outdated
|
|
||
| t.Run("mock", func(t *testing.T) { | ||
| tests.RunTestOn(t, tests.MockEnv) | ||
| t.Parallel() |
There was a problem hiding this comment.
Similar question as to previous comment?
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in [Nubia] Starknet.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the effort to break down the Paymaster PR for better review.
This PR:
paymaster_isAvailablemethod