refactor(training): migrate workout programming model to block-based … #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structure BREAKING CHANGE: Complete refactoring of workout data model - Replace WorkoutElement sets/reps/rest with flexible block-based configuration - Remove Exercise.description, Complex.description, ExerciseComplex.reps - Remove Workout.title (workouts are now templates, dates in TrainingSession) - Add WorkoutElement.commentary and tempo for coach-specific instructions - Update workout elements to use exerciseId/complexId discriminated unions - Implement BlockConfig with intensity management (percentage/RPE) per block - Support variable reps per exercise within complex movements - Update all schemas, use cases, mappers, seeders and integration tests - Add 26 realistic exercises and 7 complex movements to seeders - Create example workouts based on real weightlifting programming This provides greater flexibility for complex workout programming with multiple set/rep schemes and intensity variations within a single element.
- Remove deprecated fields from entities (description from Complex/Exercise, title from Workout, reps from ExerciseComplex) - Migrate WorkoutElement from flat structure (sets/reps/rest) to block-based programming with JSONB blocks - Update all display components to calculate totals from blocks (workout-card, workout-detail, workout-editor) - Transform workout update payload to use exerciseId/complexId instead of full exercise/complex objects - Migrate mobile components (TrainingScreen, TrainingDetailScreen) to use blocks - Update planning components to display block-based workouts - Remove unused form fields (description inputs, reps fields)
- Fix linting errors (useLiteralKeys, noUselessElse, noExplicitAny, noArrayIndexKey) - Add missing intensity property in workout seeder blocks - Complete workout seeder with all missing workouts from documentation: - Update frontend components to use block-based workout model - Replace array index keys with unique identifiers (block.order, exerciseId) - Remove unnecessary else clauses and explicit any types - Update workout schema and related components All workouts from workout-programming-model.md are now properly seeded.
- Refactor workout element display to single-column full-width layout with vertical scrolling - Add conditional display for optional fields (commentary, tempo, rest) with add/remove buttons - Apply consistent styling: rounded-full buttons, distinct background colors for exercise/complex cards - Set white background for all input and select fields - Display full exercise names in complex titles instead of abbreviations - Replace "+" symbols with Lucide Plus icons between reps in complex blocks - Add i18n support for all workout element labels, buttons, and messages - Update tab styling with colored borders and backgrounds when selected - Fix integration test by adding required intensity field in block configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…structure
BREAKING CHANGE: Complete refactoring of workout data model
This provides greater flexibility for complex workout programming with
multiple set/rep schemes and intensity variations within a single element.