SAML: disable proxy when opening auth dialog #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system environment may have proxy set, which is needed after connecting with the VPN. Using it for the actual VPN won't work, as it would try to connect to an internal proxy without success. Ensure that no proxies will be used during SAML dialogs.
By default, webkit dialog use system proxy settings. This may cause troubles if such settings exist at the system to be used only after VPN connection. So, add an option to disable it at the webkit dialog window. Signed-off-by: Mauro Carvalho Chehab <[email protected]>
kxkamil
reviewed
Dec 5, 2023
| @@ -264,6 +264,11 @@ import (NMVpnEditorPlugin *iface, const char *path, GError **error) | |||
| if (true) | |||
| nm_setting_vpn_add_data_item (s_vpn, NM_OPENCONNECT_KEY_PREVENT_INVALID_CERT, "yes"); | |||
|
|
|||
| /* Don't use system proxy settings during authentication */ | |||
| bval = g_key_file_get_boolean (keyfile, "openconnect", "DontUseProxyAuth", NULL); | |||
| if (true) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The system environment may have proxy set, which is needed after connecting with the VPN. Using it for the actual VPN won't work, as it would try to connect to an internal proxy without success.
Ensure that no proxies will be used during SAML dialogs.
Caught this while trying to connect with Palo Alto Network GlobalConnect with SAML configured to login via Microsoft cloud.