Skip to content

Correcting SBT and LP relaxations for Sigmoid, Max, Softmax, Bilinear. #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ido-shm-uel wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Correcting SBT and LP relaxations for Sigmoid, Max, Softmax, Bilinear. #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8055877
Corrected SBT, LP for Sigmoid, Softmax, Bilinear.
ido-shm-uel Sep 17, 2025
066b1d3
Correcting NLR unit tests.
ido-shm-uel Sep 17, 2025
dd2d42d
Further fixing for Max, Softmax, Bilinear IA/SBT
ido-shm-uel Sep 18, 2025
28cf80e
Clang-Format
ido-shm-uel Sep 18, 2025
39eb365
Sync Fork: Merge pull request #15 from NeuralNetworkVerification/master
ido-shm-uel Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions src/nlr/LPFormulator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/********************* */
/*! \file NetworkLevelReasoner.cpp
/*! \file LPFormulator.cpp
** \verbatim
** Top contributors (to current version):
** Guy Katz
Expand Down Expand Up @@ -977,9 +977,9 @@ void LPFormulator::addAbsoluteValueLayerToLpRelaxation( GurobiWrapper &gurobi,
double lb = std::max( 0.0, layer->getLb( i ) );
gurobi.addVariable( Stringf( "x%u", targetVariable ), lb, ub );

/*
The phase of this AbsoluteValue is not yet fixed, 0 <= y <= max(-lb, ub).
*/

// The phase of this AbsoluteValue is not yet fixed, 0 <= y <= max(-lb, ub).

// y >= 0
List<GurobiWrapper::Term> terms;
terms.append( GurobiWrapper::Term( 1, Stringf( "x%u", targetVariable ) ) );
Expand Down Expand Up @@ -1464,20 +1464,21 @@ void LPFormulator::addBilinearLayerToLpRelaxation( GurobiWrapper &gurobi,

List<NeuronIndex> sources = layer->getActivationSources( i );

const Layer *sourceLayer = _layerOwner->getLayer( sources.begin()->_layer );

Vector<double> sourceLbs;
Vector<double> sourceUbs;
Vector<double> sourceValues;
Vector<unsigned> sourceNeurons;
Vector<const Layer *> sourceLayers;
bool allConstant = true;
for ( const auto &sourceIndex : sources )
{
const Layer *sourceLayer = _layerOwner->getLayer( sourceIndex._layer );
unsigned sourceNeuron = sourceIndex._neuron;
double sourceLb = sourceLayer->getLb( sourceNeuron );
double sourceUb = sourceLayer->getUb( sourceNeuron );
String sourceName = Stringf( "x%u", sourceLayer->neuronToVariable( sourceNeuron ) );

sourceLayers.append( sourceLayer );
sourceNeurons.append( sourceNeuron );
sourceLbs.append( sourceLb );
sourceUbs.append( sourceUb );
Expand Down Expand Up @@ -1526,21 +1527,21 @@ void LPFormulator::addBilinearLayerToLpRelaxation( GurobiWrapper &gurobi,
terms.append( GurobiWrapper::Term( 1, Stringf( "x%u", targetVariable ) ) );
terms.append( GurobiWrapper::Term(
-sourceLbs[1],
Stringf( "x%u", sourceLayer->neuronToVariable( sourceNeurons[0] ) ) ) );
Stringf( "x%u", sourceLayers[0]->neuronToVariable( sourceNeurons[0] ) ) ) );
terms.append( GurobiWrapper::Term(
-sourceLbs[0],
Stringf( "x%u", sourceLayer->neuronToVariable( sourceNeurons[1] ) ) ) );
Stringf( "x%u", sourceLayers[1]->neuronToVariable( sourceNeurons[1] ) ) ) );
gurobi.addGeqConstraint( terms, -sourceLbs[0] * sourceLbs[1] );

// Upper bound: out <= u_y * x + l_x * y - l_x * u_y
terms.clear();
terms.append( GurobiWrapper::Term( 1, Stringf( "x%u", targetVariable ) ) );
terms.append( GurobiWrapper::Term(
-sourceUbs[1],
Stringf( "x%u", sourceLayer->neuronToVariable( sourceNeurons[0] ) ) ) );
Stringf( "x%u", sourceLayers[0]->neuronToVariable( sourceNeurons[0] ) ) ) );
terms.append( GurobiWrapper::Term(
-sourceLbs[0],
Stringf( "x%u", sourceLayer->neuronToVariable( sourceNeurons[1] ) ) ) );
Stringf( "x%u", sourceLayers[1]->neuronToVariable( sourceNeurons[1] ) ) ) );
gurobi.addLeqConstraint( terms, -sourceLbs[0] * sourceUbs[1] );
}
}
Expand Down
Loading
Loading