Skip to content

Conversation

luiztauffer
Copy link
Collaborator

fix #293

@luiztauffer luiztauffer requested a review from bendichter June 20, 2023 13:04
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.24%. Comparing base (fdc0309) to head (ce5427b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   66.24%   66.24%           
=======================================
  Files          35       35           
  Lines        3478     3478           
=======================================
  Hits         2304     2304           
  Misses       1174     1174           
Flag Coverage Δ
unittests 66.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CodyCBakerPhD
Copy link
Collaborator

I get a different error now on our photmetry files

ValueError                                Traceback (most recent call last)
File ~/GitHub/nwbwidgets/nwbwidgets/utils/widgets.py:51, in interactive_output.<locals>.observer(change)
     49 with out:
     50     clear_output(wait=True)
---> 51     plot = f(**fixed, **unpack_controls(controls, process_controls))
     52     plt.show()

File ~/GitHub/nwbwidgets/nwbwidgets/timeseries.py:513, in plot_grouped_traces(time_series, time_window, order, ax, figsize, group_inds, labels, colors, show_legend, dynamic_table_region_name, window, **kwargs)
    511 if len(order) <= 30:
    512     ax.set_yticks(offsets)
--> 513     ax.set_yticklabels(order)
    514 else:
    515     ax.set_yticks([])

File /opt/conda/lib/python3.10/site-packages/matplotlib/axes/_base.py:74, in _axis_method_wrapper.__set_name__.<locals>.wrapper(self, *args, **kwargs)
     73 def wrapper(self, *args, **kwargs):
---> 74     return get_method(self)(*args, **kwargs)

File /opt/conda/lib/python3.10/site-packages/matplotlib/_api/deprecation.py:297, in rename_parameter.<locals>.wrapper(*args, **kwargs)
    292     warn_deprecated(
    293         since, message=f"The {old!r} parameter of {func.__name__}() "
    294         f"has been renamed {new!r} since Matplotlib {since}; support "
    295         f"for the old name will be dropped %(removal)s.")
    296     kwargs[new] = kwargs.pop(old)
--> 297 return func(*args, **kwargs)

File /opt/conda/lib/python3.10/site-packages/matplotlib/axis.py:1969, in Axis.set_ticklabels(self, labels, minor, fontdict, **kwargs)
   1965 if isinstance(locator, mticker.FixedLocator):
   1966     # Passing [] as a list of labels is often used as a way to
   1967     # remove all tick labels, so only error for > 0 labels
   1968     if len(locator.locs) != len(labels) and len(labels) != 0:
-> 1969         raise ValueError(
   1970             "The number of FixedLocator locations"
   1971             f" ({len(locator.locs)}), usually from a call to"
   1972             " set_ticks, does not match"
   1973             f" the number of labels ({len(labels)}).")
   1974     tickd = {loc: lab for loc, lab in zip(locator.locs, labels)}
   1975     func = functools.partial(self._format_with_dict, tickd)

ValueError: The number of FixedLocator locations (1), usually from a call to set_ticks, does not match the number of labels (2).

Posted the example file on Slack to help debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Acquisition traces fails to show if the rois table is of type FibersTable

3 participants