chore: CI 검증 강화 및 Node 버전 로컬 고정 - #4
Open
hamxxn wants to merge 1 commit into
Open
Conversation
- CI push 트리거에 develop 브랜치 추가 - typecheck 단일 job을 build/lint 병렬 job으로 분리 - package.json engines.node로 Node 22 고정 - .npmrc engine-strict로 로컬 Node 버전 불일치 시 install 차단 Closes #3
|
|
||
| jobs: | ||
| typecheck: | ||
| build: |
Member
There was a problem hiding this comment.
빌드 잡 추가하면서 타입체크 제거된 것 같은데 확인한번 부탁드려요!
Collaborator
Author
There was a problem hiding this comment.
"build": "tsc -b && vite build"
build job 안으로 통합되었기에 빌드 실행하는 순간 타입체크 먼저 수행됩니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI가 typecheck만 검증하던 것을 build/lint 병렬 job으로 강화하고, push 트리거에 develop을 추가했다. 로컬 Node 버전도 engines.node + engine-strict로 강제해 CI(Node 22)와의 불일치를 사전에 차단한다.
Related Issues
PR Point (To Reviewer)
build/lint job이 checkout·pnpm 셋업 스텝을 그대로 반복하는데, GitHub Actions에서 job 간 스텝을 직접 공유할 수 없어 나온 중복이다. job이 2개뿐인 지금은 composite/reusable workflow 도입이 오히려 과할 수 있어 그대로 뒀다 — job이 늘어나면 재검토가 필요하다. Husky pre-push 훅은 의도적으로 추가하지 않았다 (CI가 이미 커버).
Screenshot
해당 없음
ETC
없음