[chore] prod 배포 v0.0.6 - #75
Open
theminjunchoi wants to merge 1 commit into
Open
Conversation
Test Coverage
|
WalkthroughLLM 댓글·답글 생성 재시도마다 성공 및 실패 토큰을 Changes재시도 토큰 집계
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/test/kotlin/com/nexters/gamss/conversation/service/CommentGenerationServiceTest.kt`:
- Around line 180-249: Extend the test coverage around the existing
comment-generation retry tests to verify reply-generation failure-then-success
and final-failure flows, accumulation of tokens in logs when a retryable failure
is followed by a non-retryable exception, and the successful
GenerationResult.usedTokens value equals the final successful attempt’s tokens.
Cover all three logging branches while preserving the existing explicit
assertions for comment success and failure.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d3a8f211-4f49-46aa-bbfa-5b3e5d8cfe53
📒 Files selected for processing (4)
src/main/kotlin/com/nexters/gamss/conversation/service/CommentGenerationService.ktsrc/main/kotlin/com/nexters/gamss/conversation/service/TokenUsageAccumulator.ktsrc/test/kotlin/com/nexters/gamss/conversation/service/CommentGenerationServiceTest.ktsrc/test/kotlin/com/nexters/gamss/conversation/service/TokenUsageAccumulatorTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 prod 승격 (dev → prod), v0.0.5 → v0.0.6
포함 변경
generation_log에 기록되어 비용·일일 토큰 상한이 과소 집계되던 문제.TokenUsageAccumulator를 도입해 성공·최종실패·재시도불가 로그 모두 전 시도 합산값으로 기록.🗄️ DB 마이그레이션 (prod에 신규 적용)
🌐 API 영향
GenerationResult.usedTokens(성공 시도 표시값)도 그대로입니다.generation_log기록값만 정확해집니다.이 수정의 실제 효과는 prod에서만 나타납니다. 일일 토큰 상한은
gamss.token-limit.enabled: true인 prod 프로필에서만 켜지기 때문에(application-prod.yml), dev에서는 집계 정확도 개선을 체감할 수 없었습니다.배포 후:
daily_token_limit조정이 가능합니다.✅ 확인 완료
dev-54d75ab)Summary by CodeRabbit
개선 사항
테스트