WIP: Permission Claims - Group Management [skip-ci] #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rackstar
changed the title
|
Discussion over slack, putting it here for visibility:
assessingGroupId: groupId.toUint32()
string calldata ipfsMetadata
|
roxdanila
reviewed
May 19, 2025
|
|
||
| mapping(address assessor => EnumerableSet.UintSet) private _groupsForAssessor; | ||
|
|
||
| mapping(uint productTypeId => AssessmentData) private _assessmentData; |
There was a problem hiding this comment.
should this be here or in the ProductType struct to ensure each product type always has an AssessmentData?
duxxud
force-pushed
the
feat/permissioned-assessment
branch
from
ac47ecf to
07eaec7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1386
Describe the changes made in this PR. A link to the issue is enough if it contains all the relevant information.
Testing
Explain how you tested your changes to ensure they work as expected.
Checklist