-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interface-wide default calling convention #87
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=========================================
- Coverage 89.44% 89.35% -0.1%
=========================================
Files 114 114
Lines 5516 5532 +16
Branches 456 461 +5
=========================================
+ Hits 4934 4943 +9
- Misses 576 583 +7
Partials 6 6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
- Coverage 89.09% 86.83% -2.27%
==========================================
Files 115 116 +1
Lines 5642 5584 -58
Branches 497 463 -34
==========================================
- Hits 5027 4849 -178
- Misses 604 717 +113
- Partials 11 18 +7
Continue to review full report at Codecov.
|
So based on some of the discussions on github, here's an outline of the test cases that need to be implemented: Case 1
Expected ResultsMethod uses the calling convention from the NativeSymbols attribute and can be successfully called. Case 2
Expected ResultsMethod one uses the calling convention from the NativeSymbols attribute. Method two uses the calling convention set in its specific NativeSymbol attribute. Case 3
Expected ResultsMethods from interface one uses the calling convention from the NativeSymbols attribute on their interface. Methods from interface two does not. Case 4
Expected ResultsMethods from interface one uses the calling convention from the NativeSymbols attribute on their interface. Methods from interface two uses the calling convention from the NativeSymbols attribute on their interface. |
Can you rebase this on master and ensure the tests pass before I review it? |
NativeSymbolsAttribute
updated to have a specifiable interface-wide calling convention, along with internal logic to accommodate.