-
Notifications
You must be signed in to change notification settings - Fork 31
Fix: use polite flag for chafa #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
its still not working after the commit the images are pixelated alot |
|
Tested, can confirm this works |
|
Tested here too, works fine! Would really like to see this merged |
|
@NikitaIvanovV can we please get this merged? |
|
Also confirming this works, using the Foot terminal |
|
For the time being, you may be able to set a custom preview that is basically |
|
A temporal fix is paste in your preview image image/* {{
chafa -s "${w}x${h}" -f sixels --polite on "$f"
}} |
|
Does this even work? I compiled ctpv with this commit but I still get an error: |
Add to |
EDIT: nvm it was an issue on my end. |
Add missing pdf preview dependency. `ctpv` uses `pdftoppm` [1] to preview pdf files. Required dependency was not included on the last PR targeting `ctpv`, although it added the tools for other ftypes [2]. Fix chafa image privews by passing the missing flag via a patch. This comes from a year long bug fix PR open at upstream, for details refer there [3]. [1]: https://github.com/NikitaIvanovV/ctpv/blob/4efa0f976eaf8cb814e0aba4f4f1a1d12ee9262e/README.md#L58 [2]: github:NixOS#223487 [3]: github:NikitaIvanovV/ctpv#90
… (taken from fork ctpv-updated) - new font preview using imagemagick - new audio preview including important song properties and coverart - removed information about lf-fork (NikitaIvanovV#72) - add polite flag for chafa (NikitaIvanovV#90) - replace "convert" with "magick" (NikitaIvanovV#104) - sped up video previews - use rsvg-convert for svg preview - use soffice instead of libreoffice for libreoffice previews - add highlighting for cat - merged NikitaIvanovV#72, NikitaIvanovV#90, NikitaIvanovV#104 - fixed NikitaIvanovV#61, NikitaIvanovV#103
Chafa with sixel support is broken with lf. The problem and a fix is described in this post gokcehan/lf#1582