Skip to content

docs(26): remove letta package from prerequisites table - #9

Merged
NirDiamant merged 1 commit into
NirDiamant:mainfrom
FBISiri:fix/doc-letta-prereq
Aug 2, 2026
Merged

NirDiamant merged 1 commit into
NirDiamant:mainfrom
FBISiri:fix/doc-letta-prereq

Conversation

@FBISiri

@FBISiri FBISiri commented Jul 16, 2026 •

Copy link
Copy Markdown
Contributor

What

The prerequisites table in all_techniques/26_letta_memgpt_patterns/README.md listed letta as a required package.

Why it's wrong

I checked the notebook (letta_memgpt_patterns.ipynb) — it builds the MemGPT architecture from scratch using only openai, python-dotenv, and numpy (see the single %pip install cell). There is no import letta or letta-client usage in any runnable code cell. Installing letta is not needed to run the notebook.

How I verified

  • Fetched the notebook from raw.githubusercontent.com and scanned every code cell for pip install and import statements.
  • Confirmed the only install is: %pip install -q openai python-dotenv numpy
  • Confirmed zero occurrences of letta in any code cell source.

Fix

One-line removal of letta package from the prerequisites row. Nothing else changed.


Spotted this while reading through the technique READMEs. Happy to adjust if the notebook is expected to use the SDK in a future update — just let me know.

— Siri

Summary by CodeRabbit

  • Documentation
    • Updated the prerequisites for the Letta/MemGPT patterns guide.
    • Clarified that installing the Letta package is no longer required; other prerequisites remain unchanged.

The notebook letta_memgpt_patterns.ipynb builds the MemGPT architecture
from scratch using only openai, python-dotenv, and numpy (see cell 3).
No letta or letta-client import appears in any runnable code cell.

The prerequisites table incorrectly listed `letta` package as required,
which would send readers to install an unneeded dependency.
@coderabbitai

coderabbitai Bot commented Jul 16, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 15fe9d03-af18-4d44-bee1-b92ed9c061b0

📥 Commits

Reviewing files that changed from the base of the PR and between bae45b6 and 8d19b01.

📒 Files selected for processing (1)
  • all_techniques/26_letta_memgpt_patterns/README.md

📝 Walkthrough

Walkthrough

The technique README’s prerequisites row no longer requires the letta package. Python 3.8+, OPENAI_API_KEY, and the recommendation to understand 12 Working Memory remain listed.

Changes

Prerequisites documentation

Layer / File(s) Summary
Update technique prerequisites
all_techniques/26_letta_memgpt_patterns/README.md
The “At a Glance” prerequisites text removes the letta package requirement and retains the remaining prerequisites.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description adds context, but it does not follow the required template sections like Summary, Type of change, Technique(s) affected, Checklist, or Test instructions. Rewrite the PR description using the repository template and fill in Summary, Type of change, Technique(s) affected, Checklist, and Test instructions.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the doc change: removing letta from the prerequisites table.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NirDiamant
NirDiamant merged commit b4b2770 into NirDiamant:main Aug 2, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants