Clamp loop_start/loop_length in delPart to ensure setupPingPingLoop doesn't occasionally read/write past end of sample buffer#40
Open
prayerie wants to merge 1 commit into
Conversation
Author
|
|
Author
|
Actually I tested around a bit and I must have misremembered, this is the only clamping necessary; the other thing was changing memcpy to memmove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rare edge case I found with asie's PC port and then confirmed manually in the NDS version.
Occasionally when deleting parts of audio data with a ping-pong looping sample, loop_start / loop_length can exceed the end of the sample by a couple of bytes (please do confirm in case I'm incorrect though). Adding these seemed to resolve the issue (there is still a tiny buffer overread in
setupPingPongLoop, but it's unrelated and presumably benign).