Add test to validate fix for fromTOML assertion not hit #14292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Add a unit test specifically for the issue NixOS#11972 which said that an assertion in the fromTOML builtin was hit when called from the C API. fixes NixOS#11972
fzakaria
force-pushed
the
fzakaria/issue-11972
branch
from
b25d81a to
b7118b7
Compare
edolstra
reviewed
Oct 20, 2025
| /** | ||
| * @brief Validates the fix for https://github.com/NixOS/nix/issues/11972 | ||
| */ | ||
| TEST_F(nix_api_expr_test, fromTOML_invalid_syntax_should_error_gracefully) |
There was a problem hiding this comment.
It's easier/faster to do this as a language test in tests/functional/lang. Those can also check for error messages, see eval-fail-*.
There was a problem hiding this comment.
Do those test the C API ?
The original issue was specifically with the C-api vs. the C++ API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a unit test specifically for the issue #11972 which said that an assertion in the fromTOML builtin was hit when called from the C API.
fixes #11972
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.