refactor(libstore/s3-binary-cache-store): implement upload()
#14356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
store
lovesegfault
force-pushed
the
s3-upload
branch
9 times, most recently
from
151d0e4 to
3695f0d
Compare
|
🎉 All dependencies have been resolved ! |
lovesegfault
force-pushed
the
s3-upload
branch
2 times, most recently
from
66a777d to
51bf53b
Compare
Mic92
approved these changes
Oct 29, 2025
Ericson2314
requested changes
Oct 29, 2025
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Just talked about sticking a protected method in HttpBinaryCacheStore so we have less duplication.
lovesegfault
force-pushed
the
s3-upload
branch
4 times, most recently
from
bd4751b to
69e907a
Compare
github-actions
bot
added
the
fetching
lovesegfault
force-pushed
the
s3-upload
branch
5 times, most recently
from
d8c8e79 to
8560807
Compare
Stop delegating to `HttpBinaryCacheStore::upsertFile` and instead handle compression in the S3 store's `upsertFile` override, then call our own `upload()` method. This separation is necessary for future multipart upload support.
lovesegfault
force-pushed
the
s3-upload
branch
from
8560807 to
e636888
Compare
xokdvium
approved these changes
Oct 30, 2025
xokdvium
reviewed
Oct 30, 2025
Ericson2314
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This stops us from just delegating to
HttpBinaryCacheStore::upsertFile,handling compression in our
upsertFileoverride, which will be necessary formultipart uploads.
Context
Part-Of: #14330
Depends-On: #14377, #14421
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.