Skip to content

go-ethereum: 1.14.6 -> 1.14.8 #334768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RaghavSood merged 1 commit into from
Aug 15, 2024
Merged

go-ethereum: 1.14.6 -> 1.14.8 #334768

RaghavSood merged 1 commit into from
Aug 15, 2024

Conversation

@jeremyschlatter
Copy link
Contributor

@jeremyschlatter jeremyschlatter commented Aug 15, 2024 •
edited
Loading

Release notes: https://github.com/ethereum/go-ethereum/releases/tag/v1.14.8

Note that cmd/p2psim was removed in ethereum/go-ethereum#30250

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jeremyschlatter jeremyschlatter mentioned this pull request Aug 15, 2024
Closed
13 tasks
@ofborg ofborg bot requested a review from RaghavSood August 15, 2024 04:33
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 15, 2024
@RaghavSood
Copy link
Member

RaghavSood commented Aug 15, 2024

Result of nixpkgs-review pr 334768 run on aarch64-darwin 1

3 packages built:
  • go-ethereum
  • go-ethereum.clef
  • go-ethereum.geth

@RaghavSood RaghavSood merged commit 95b3c2e into NixOS:master Aug 15, 2024
@jeremyschlatter jeremyschlatter deleted the go-ethereum-1-14-8 branch August 15, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaghavSood RaghavSood RaghavSood approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeremyschlatter @RaghavSood