modrinth-app-unwrapped: 0.10.5 -> 0.10.23 #466573

Hythera · 2025-11-30T13:58:01Z

Diff: modrinth/code@v0.10.5...v0.10.23

Things done

Add a 👍 reaction to pull requests you find important.

Eveeifyeve · 2025-12-01T02:00:39Z

Testing on real hardware and vm for linux without github action.

Eveeifyeve

Please fix the issues.

pkgs/by-name/mo/modrinth-app-unwrapped/package.nix

Hythera · 2025-12-01T07:17:24Z

Still doesn't build on darwin with the same error.

Eveeifyeve · 2025-12-01T18:17:17Z

I seems it cidre causing issues to build not finding a dir.

error: failed to run custom build command for `cidre v0.11.3`

Caused by:

process didn't exit successfully: /nix/build/nix-14596-1689605405/source/target/release/build/cidre-5bfc87287549a064/build-script-build (exit status: 101)

--- stdout

cargo:rustc-link-lib=clang_rt.osx

cargo:rustc-link-search=/nix/store/qk20nysrc2170f1mal5k6r0axqn6jmfj-clang-wrapper-21.1.2/resource-root/lib/darwin

cargo:rerun-if-changed=./pomace/

--- stderr

thread 'main' (164539) panicked at /nix/build/nix-14596-1689605405/modrinth-app-unwrapped-0.10.21-vendor/cidre-0.11.3/build.rs:131:14:

called Result::unwrap() on an Err value: Os { code: 2, kind: NotFound, message: "No such file or directory" }

note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

warning: build failed, waiting for other jobs to finish...

Error failed to build app: failed to build app

Hythera · 2025-12-01T18:24:07Z

Yea I looked at the project a bit and the line that was causing it. Not really sure what the root issue is tho. As I don't have a darwin device / experience with it...

Eveeifyeve · 2025-12-01T18:24:20Z

It needs xcodebuild looking at the build.rs: https://github.com/yury/cidre/blob/6239660a051393c2f6d18ea969a7183e13ce6258/cidre/build.rs#L105-L132

I would say add xcbuild to this package and it should fix it.

SuperSandro2000 · 2025-12-01T18:26:45Z

Please rebase after #463705 got merged

Hythera · 2025-12-01T18:28:45Z

#463705 did not fix the darwin build tho?

Eveeifyeve · 2025-12-01T18:40:11Z

#463705 did not fix the darwin build tho?

So please rebase to pull all the changes from the pr, wtth updating it and then add xcbuild to your buildInputs.

Eveeifyeve · 2025-12-01T19:19:31Z

There is still issues with the dep.json please see the failing checks for more info.

Hythera · 2025-12-01T19:22:27Z

I know, I'm updating it right now :)

encode42 · 2025-12-01T20:01:44Z

Should the commit/PR name be changed since it's based on 0.10.5 now?

Hythera · 2025-12-21T18:52:33Z

`nixpkgs-review` result for #466573

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 466573
Commit: 9990e0d6a3eae412c4a220c2e154bdcd20df4ea9 (subsequent changes)
Merge: 12f02faefe29514f8626dc6e2892aa7c33a7844c

Logs: https://github.com/Hythera/nixpkgs-review-gha/actions/runs/20413929627

`x86_64-linux`

✅ 2 packages built:

modrinth-app
modrinth-app-unwrapped

encode42 · 2025-12-21T19:52:08Z

p.s. you might want to update this to 0.10.23 now, since it fixes a critical bug with NeoForge >1.21.10 installations!

Hythera · 2025-12-21T21:03:39Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 466573
Commit: 9886c55c71da9f00295d25af884be66afef1cc14

`x86_64-linux`

✅ 3 packages built:

modrinth-app
modrinth-app-unwrapped
nixpkgs-manual

Hythera · 2025-12-26T18:34:43Z

I've marked darwin as broken for now as it is blocking the update for the Linux users. Sorry for those who had to wait...

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 466573
Commit: 990c4a36dc9fd788347cedacbcd0996e017b765b (subsequent changes)
Merge: a49d63c6961519a4dc52b36b4989b913fb820e84

Logs: https://github.com/Hythera/nixpkgs-review-gha/actions/runs/20527083292

`x86_64-linux`

✅ 2 packages built:

modrinth-app
modrinth-app-unwrapped

`aarch64-linux`

✅ No rebuilds

`x86_64-darwin`

✅ No rebuilds

`aarch64-darwin`

✅ No rebuilds

nixpkgs-ci · 2025-12-26T19:04:18Z

Successfully created backport PR for release-25.11:

[Backport release-25.11] modrinth-app-unwrapped: 0.10.5 -> 0.10.23 #474404

nixpkgs-ci bot requested a review from getchoo November 30, 2025 14:02

nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Nov 30, 2025

This comment was marked as outdated.

Sign in to view

Eveeifyeve suggested changes Dec 1, 2025

View reviewed changes

pkgs/by-name/mo/modrinth-app-unwrapped/package.nix Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

Hythera force-pushed the pkgs/modrinth-app-unwrapped/0.10.21 branch from 36b09bc to 07ee2e2 Compare December 1, 2025 06:19

This comment was marked as outdated.

Sign in to view

nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 1, 2025

Hythera force-pushed the pkgs/modrinth-app-unwrapped/0.10.21 branch 3 times, most recently from 35f1d47 to c30e9be Compare December 1, 2025 19:11

nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 1, 2025

Hythera force-pushed the pkgs/modrinth-app-unwrapped/0.10.21 branch from c30e9be to dc62f40 Compare December 1, 2025 19:22

This comment was marked as outdated.

Sign in to view

Hythera force-pushed the pkgs/modrinth-app-unwrapped/0.10.21 branch from dc62f40 to f3cab1d Compare December 1, 2025 20:04

Hythera changed the title ~~modrinth-app-unwrapped: fix build, 0.10.5 -> 0.10.21~~ modrinth-app-unwrapped: fix build, 0.10.5 -> 0.10.22 Dec 21, 2025

Hythera force-pushed the pkgs/modrinth-app-unwrapped/0.10.21 branch from 9990e0d to 9886c55 Compare December 21, 2025 20:34

Hythera changed the title ~~modrinth-app-unwrapped: fix build, 0.10.5 -> 0.10.22~~ modrinth-app-unwrapped: fix build, 0.10.5 -> 0.10.23 Dec 21, 2025

Hythera added 2 commits December 26, 2025 18:58

modrinth-app-unwrapped: 0.10.5 -> 0.10.23

799e0c5

modrinth-app: add jdk25

ef4e7c1

Hythera force-pushed the pkgs/modrinth-app-unwrapped/0.10.21 branch 2 times, most recently from 67d2234 to 5c5e542 Compare December 26, 2025 18:04

Hythera requested a review from Eveeifyeve December 26, 2025 18:04

modrinth-app,modrinth-app-unwrapped: mark darwin as broken

990c4a3

Hythera force-pushed the pkgs/modrinth-app-unwrapped/0.10.21 branch from 5c5e542 to 990c4a3 Compare December 26, 2025 18:09

Hythera changed the title ~~modrinth-app-unwrapped: fix build, 0.10.5 -> 0.10.23~~ modrinth-app-unwrapped: 0.10.5 -> 0.10.23 Dec 26, 2025

Hythera added the 8.has: package (update) This PR updates a package to a newer version label Dec 26, 2025

nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Dec 26, 2025

Scrumplex approved these changes Dec 26, 2025

View reviewed changes

Scrumplex added this pull request to the merge queue Dec 26, 2025

Scrumplex added the backport release-25.11 Backport PR automatically label Dec 26, 2025

nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Dec 26, 2025

Merged via the queue into NixOS:master with commit e1e99ec Dec 26, 2025
33 of 37 checks passed

nixpkgs-ci bot mentioned this pull request Dec 26, 2025

[Backport release-25.11] modrinth-app-unwrapped: 0.10.5 -> 0.10.23 #474404

Merged

github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Dec 26, 2025

Hythera deleted the pkgs/modrinth-app-unwrapped/0.10.21 branch December 28, 2025 13:16

Uh oh!

modrinth-app-unwrapped: 0.10.5 -> 0.10.23 #466573

modrinth-app-unwrapped: 0.10.5 -> 0.10.23 #466573

Conversation

Hythera commented Nov 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Eveeifyeve commented Dec 1, 2025

Uh oh!

Eveeifyeve left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Hythera commented Dec 1, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Eveeifyeve commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Hythera commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eveeifyeve commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SuperSandro2000 commented Dec 1, 2025

Uh oh!

Hythera commented Dec 1, 2025

Uh oh!

Eveeifyeve commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eveeifyeve commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Hythera commented Dec 1, 2025

Uh oh!

encode42 commented Dec 1, 2025

Uh oh!

This comment was marked as outdated.

Hythera commented Dec 21, 2025

nixpkgs-review result for #466573

x86_64-linux

Uh oh!

encode42 commented Dec 21, 2025

Uh oh!

Hythera commented Dec 21, 2025

nixpkgs-review result

x86_64-linux

Uh oh!

Hythera commented Dec 26, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

Uh oh!

Uh oh!

nixpkgs-ci bot commented Dec 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Hythera commented Nov 30, 2025 •

edited

Loading

Eveeifyeve commented Dec 1, 2025 •

edited

Loading

Hythera commented Dec 1, 2025 •

edited

Loading

Eveeifyeve commented Dec 1, 2025 •

edited

Loading

Eveeifyeve commented Dec 1, 2025 •

edited

Loading

Eveeifyeve commented Dec 1, 2025 •

edited

Loading

`nixpkgs-review` result for #466573

`x86_64-linux`

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`