Skip to content

wrapNonDeterministicGcc: override the param cc of ccWrapper instead of override drv attr env.cc #477124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
n0099 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wrapNonDeterministicGcc: override the param cc of ccWrapper instead of override drv attr env.cc #477124

n0099 wants to merge 1 commit into from

Conversation

@n0099
Copy link
Contributor

@n0099 n0099 commented Jan 5, 2026 •
edited
Loading

This affect the value of attr path pkgs.fastStdenv.cc.cc.buildFlags:
before: [ ]
after: [ "profiledbootstrap" ]

ref: c577eb6

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jan 5, 2026
n0099 added a commit to n0099/nixos that referenced this pull request Jan 5, 2026
@n0099
* fix pkgs.fastStdenv is broken: NixOS/nixpkgs#477124 @ stdenv.nix
b6fee86 
* move https://github.com/n0099/nixos/blob/c5a3f680c39d8292da72a3cb8a421989d066f17b/modules/stdenv.nix into `stdenv.nix` and enable it based on a new options
@ modules
@nixos-discourse
Copy link

nixos-discourse commented Jan 6, 2026

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/6240

@n0099
wrapNonDeterministicGcc: override the param cc of ccWrapper inste…
a85d008 
…ad of override drv attr `env.cc`

This affect the value of attr path `pkgs.fastStdenv.cc.cc.buildFlags`:
before: `[ ]`
after: `[ "profiledbootstrap" ]`

ref: c577eb6
@n0099 n0099 changed the title wrapNonDeterministicGcc: override the param cc of ccWrapper instead of override drv attrs env.cc wrapNonDeterministicGcc: override the param cc of ccWrapper instead of override drv attr env.cc Jan 6, 2026
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@Artturin Artturin Awaiting requested review from Artturin

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@n0099 @nixos-discourse @SuperSandro2000