gexiv2_0_16: init at 0.16.0#502190
Conversation
jackrosenberg
left a comment
There was a problem hiding this comment.
Hey hey, package looks good overall. Sadly, we don't accept new packages that are not going to be maintained. If you are interested in maintaining this, please add yourself to meta.maintainers
|
First of all, thank you for the review and sorry for the late reply. |
|
Of course it's no problem! Welcome to the team! One last thing, you'll need to change the commit structure a bit (commit conventions). There will need to be 2 commits, the one adding you to the maintainers list needs to be first. The second is just the rest of your commits squashed into one :) |
|
Oops, I should've checked on my side first, thanks. |
|
|
Appended |
|
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
Sorry for the back-and-forth on this, and thank you for taking another look.
No worries, that's what review is for :) Thank you for sticking with this, nixpkgs can always use more good maintainers.
Upstream changelog: https://gitlab.gnome.org/GNOME/gexiv2/-/blob/master/NEWS
This PR adds a new package alongside
gexiv2(0.14.x) due to API break, as suggested in #501263The
pkgconfigfile changed fromgexiv2.pctogexiv2-0.16.pc, breaking downstream reverse dependenciesPackaging changes from
gexiv2:gtk-doc/docbook-xsl-nons/docbook_xml_dtd_43togi-docgenpreCheckto match new SONAME (libgexiv2-0.16.so.4)GI_TYPELIB_PATHexport inpreCheckpostFixupto correctly place docs into$devdocverified
.pcfile (gexiv2-0.16.pc) and.sopresent in output.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.