Skip to content

gexiv2_0_16: init at 0.16.0#502190

Open
7591yj wants to merge 2 commits intoNixOS:masterfrom
7591yj:gexiv2-new-pkg
Open

gexiv2_0_16: init at 0.16.0#502190
7591yj wants to merge 2 commits intoNixOS:masterfrom
7591yj:gexiv2-new-pkg

Conversation

@7591yj
Copy link
Copy Markdown

@7591yj 7591yj commented Mar 22, 2026

Upstream changelog: https://gitlab.gnome.org/GNOME/gexiv2/-/blob/master/NEWS

This PR adds a new package alongside gexiv2 (0.14.x) due to API break, as suggested in #501263
The pkgconfig file changed from gexiv2.pc to gexiv2-0.16.pc, breaking downstream reverse dependencies

Packaging changes from gexiv2:

  • switched doc toolchain from gtk-doc/docbook-xsl-nons/docbook_xml_dtd_43 to gi-docgen
  • fixed library symlink name in preCheck to match new SONAME (libgexiv2-0.16.so.4)
  • added GI_TYPELIB_PATH export in preCheck
  • added postFixup to correctly place docs into $devdoc

verified .pc file (gexiv2-0.16.pc) and .so present in output.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (new) This PR adds a new package 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! labels Mar 22, 2026
@7591yj 7591yj mentioned this pull request Mar 22, 2026
13 tasks
@7591yj 7591yj marked this pull request as ready for review March 22, 2026 12:37
@nixpkgs-ci nixpkgs-ci Bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Mar 22, 2026
Copy link
Copy Markdown
Member

@jackrosenberg jackrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey hey, package looks good overall. Sadly, we don't accept new packages that are not going to be maintained. If you are interested in maintaining this, please add yourself to meta.maintainers

Comment thread pkgs/by-name/ge/gexiv2_0_16/package.nix Outdated
Comment thread pkgs/by-name/ge/gexiv2_0_16/package.nix Outdated
@nixpkgs-ci nixpkgs-ci Bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Apr 18, 2026
@nixpkgs-ci nixpkgs-ci Bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Apr 27, 2026
@7591yj
Copy link
Copy Markdown
Author

7591yj commented Apr 27, 2026

First of all, thank you for the review and sorry for the late reply.
I would be happy to maintain the package, although this would be my first time contributing to the project.
If that is not an issue, I have added myself to meta.maintainers in the last commit.

@jackrosenberg
Copy link
Copy Markdown
Member

Of course it's no problem! Welcome to the team!

One last thing, you'll need to change the commit structure a bit (commit conventions). There will need to be 2 commits, the one adding you to the maintainers list needs to be first. The second is just the rest of your commits squashed into one :)

@7591yj
Copy link
Copy Markdown
Author

7591yj commented Apr 28, 2026

Oops, I should've checked on my side first, thanks.
I've squashed the commits and reordered them so the maintainer update comes first.
The branch has been force-pushed due to the rebase.

@jackrosenberg
Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 502190
Commit: 097e028fe515a5e0b3f7239e3d27c6d61f733c10


x86_64-linux

❌ 3 packages failed to build:
  • gexiv2_0_16
  • gexiv2_0_16.dev
  • gexiv2_0_16.devdoc

Error logs: `x86_64-linux`
gexiv2_0_16
Program /nix/store/kw0yjwbvw6arwgwaa3p8rz46qsgy4626-glib-2.86.3-dev/bin/glib-mkenums found: YES (/nix/store/kw0yjwbvw6arwgwaa3p8rz46qsgy4626-glib-2.86.3-dev/bin/glib-mkenums)
Dependency glib-2.0 found: YES 2.86.3 (cached)
Program /nix/store/kw0yjwbvw6arwgwaa3p8rz46qsgy4626-glib-2.86.3-dev/bin/glib-mkenums found: YES (/nix/store/kw0yjwbvw6arwgwaa3p8rz46qsgy4626-glib-2.86.3-dev/bin/glib-mkenums)
Program update-def-file.sh found: YES (/build/gexiv2-0.16.0/build-aux/update-def-file.sh)
Found pkg-config: YES (/nix/store/v7mjkia7ki79s5i24ldbzq1khalhgzk0-pkg-config-wrapper-0.29.2/bin/pkg-config) 0.29.2
Run-time dependency gobject-introspection-1.0 found: YES 1.86.0
Dependency gobject-introspection-1.0 found: YES 1.86.0 (cached)
Program /nix/store/k4fqld0wqfws3ifkh9ypf6ihx4pd3853-gobject-introspection-1.86.0-dev/bin/g-ir-scanner found: YES (/nix/store/k4fqld0wqfws3ifkh9ypf6ihx4pd3853-gobject-introspection-1.86.0-dev/bin/g-ir-scanner)
Dependency gobject-introspection-1.0 found: YES 1.86.0 (cached)
Program /nix/store/k4fqld0wqfws3ifkh9ypf6ihx4pd3853-gobject-introspection-1.86.0-dev/bin/g-ir-compiler found: YES (/nix/store/k4fqld0wqfws3ifkh9ypf6ihx4pd3853-gobject-introspection-1.86.0-dev/bin/g-ir-compiler)
Program vapigen found: YES (/nix/store/zzm977f1z7nnqfjagx6hafb2qgd652cz-vala-0.56.18/bin/vapigen)
Did not find CMake 'cmake'
Found CMake: NO
Build-time dependency gi-docgen found: NO (tried pkgconfig and cmake)
Looking for a fallback subproject for the dependency gi-docgen
ERROR: Subproject gi-docgen is buildable: NO

meson.build:46:15: ERROR: Automatic wrap-based subproject downloading is disabled

A full log can be found at /build/gexiv2-0.16.0/build/meson-logs/meson-log.txt

Comment thread pkgs/by-name/ge/gexiv2_0_16/package.nix
@7591yj
Copy link
Copy Markdown
Author

7591yj commented Apr 29, 2026

Appended gi-docgen to buildInputs and verified locally(x86_64-linux) with nixpkgs-review that the package builds correctly.
Sorry for the back-and-forth on this, and thank you for taking another look.

@jackrosenberg
Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 502190
Commit: 39b022f8e77f1e157f6eaea330e2794e41410208


x86_64-linux

✅ 3 packages built:
  • gexiv2_0_16
  • gexiv2_0_16.dev
  • gexiv2_0_16.devdoc

Copy link
Copy Markdown
Member

@jackrosenberg jackrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

Sorry for the back-and-forth on this, and thank you for taking another look.

No worries, that's what review is for :) Thank you for sticking with this, nixpkgs can always use more good maintainers.

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants