Skip to content

gradia: fix patch for blueprint-compiler 0.20.4#502830

Merged
pbsds merged 1 commit intoNixOS:masterfrom
claymorwan:fix-gradia-blueprint
Apr 6, 2026
Merged

gradia: fix patch for blueprint-compiler 0.20.4#502830
pbsds merged 1 commit intoNixOS:masterfrom
claymorwan:fix-gradia-blueprint

Conversation

@claymorwan
Copy link
Copy Markdown
Contributor

Add patch from this PR to fix gradia not building with blueprint-compiler 0.20.4

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested review from Cameo007 and Henry-Hiles March 23, 2026 21:54
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 23, 2026
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Mar 23, 2026
@Cameo007
Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 502830
Commit: bffa60aeb23093f689ea93d356a522009c12ad43


x86_64-linux

✅ 1 package built:
  • gradia

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Mar 24, 2026
Copy link
Copy Markdown
Contributor

@dtomvan dtomvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with:

git fetch upstream master
git fetch r-ryantm auto-update/blueprint-compiler
git fetch claymorwan fix-gradia-blueprint
git switch master && git reset --hard upstream/master
git merge --no-edit r-ryantm/auto-update/blueprint-compiler
git merge --no-edit claymorwan/fix-gradia-blueprint
nix-build -A gradia

Tho I think a committer should just add this patch to #496793. Thanks for fixing this. I could really use that blueprint-compiler bump for bazaar :)

@dtomvan
Copy link
Copy Markdown
Contributor

dtomvan commented Mar 25, 2026

Though in the future you might want to use fetchpatch2, though this patch is simple enough it could've been a substituteInPlace, so I'll give it a pass for now 😅

@claymorwan
Copy link
Copy Markdown
Contributor Author

o yea i legit forgot i could use fetchpatch2, it's my first time PR'ing a patch i'll try to remember next time thanks

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Mar 25, 2026
@pbsds pbsds added this pull request to the merge queue Apr 6, 2026
Merged via the queue into NixOS:master with commit d7cbe7b Apr 6, 2026
39 of 41 checks passed
ilai-deutel pushed a commit to ilai-deutel/nixpkgs that referenced this pull request Apr 6, 2026
@Cameo007 Cameo007 mentioned this pull request Apr 24, 2026
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants