Skip to content

[WIP] Remove Nbdev #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 74 commits into
base: main
Choose a base branch
from
Draft

[WIP] Remove Nbdev #644

wants to merge 74 commits into from

Conversation

JQGoh
Copy link
Collaborator

@JQGoh JQGoh commented May 20, 2025

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is mainly used for comparison - like how does the jupyternotebook look like after we remove the directives "#| hide" related contents.

dev_requirements = black datasetsforecast fire hierarchicalforecast ipython<=8.32.0 ipywidgets jupyterlab nbdev neuralforecast numpy<2 plotly polars pre-commit pyreadr<0.5.3 python-dotenv pyyaml setuptools<70 statsforecast tabulate
dev_requirements = black datasetsforecast fire hierarchicalforecast ipython<=8.32.0 ipywidgets
jupyterlab nbdev neuralforecast numpy<2 plotly polars pre-commit pyreadr<0.5.3
python-dotenv pyyaml setuptools<70 statsforecast tabulate shap pytest pytest-cov
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that shap is also used as part of the notebook cell run. Include this.

distributed_requirements = fugue[dask,ray,spark]>=0.8.7 dask<=2024.12.1 pandas<2.2 ray<2.6.3
plotting_requirements = utilsforecast[plotting]
date_extra_requirements = holidays
date_extra_requirements = holidays pandas_market_calendars
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that pandas_msarket_calendars is also used as part of the notebook cell run. Include this.

model_id1 = str(uuid.uuid4())

return SimpleNamespace(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we get the chance to have a closer look at the incremental changes as suggested by GPT, we can review and think about would it make sense to group a set of related settings in one place, rather than simply accepting the generated fixtures like

@pytest.fixture
def h():
    return 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant