-
Notifications
You must be signed in to change notification settings - Fork 230
[WIP] Remove Nbdev #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] Remove Nbdev #644
Conversation
This reverts commit dbd5314.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
nbs/src/new_nixtla_client.ipynb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is mainly used for comparison - like how does the jupyternotebook look like after we remove the directives "#| hide" related contents.
dev_requirements = black datasetsforecast fire hierarchicalforecast ipython<=8.32.0 ipywidgets jupyterlab nbdev neuralforecast numpy<2 plotly polars pre-commit pyreadr<0.5.3 python-dotenv pyyaml setuptools<70 statsforecast tabulate | ||
dev_requirements = black datasetsforecast fire hierarchicalforecast ipython<=8.32.0 ipywidgets | ||
jupyterlab nbdev neuralforecast numpy<2 plotly polars pre-commit pyreadr<0.5.3 | ||
python-dotenv pyyaml setuptools<70 statsforecast tabulate shap pytest pytest-cov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that shap
is also used as part of the notebook cell run. Include this.
distributed_requirements = fugue[dask,ray,spark]>=0.8.7 dask<=2024.12.1 pandas<2.2 ray<2.6.3 | ||
plotting_requirements = utilsforecast[plotting] | ||
date_extra_requirements = holidays | ||
date_extra_requirements = holidays pandas_market_calendars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that pandas_msarket_calendars
is also used as part of the notebook cell run. Include this.
model_id1 = str(uuid.uuid4()) | ||
|
||
return SimpleNamespace( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we get the chance to have a closer look at the incremental changes as suggested by GPT, we can review and think about would it make sense to group a set of related settings in one place, rather than simply accepting the generated fixtures like
@pytest.fixture
def h():
return 5
No description provided.